fix: Omnichannel queue starting multiple times due to race condition #34062
+221
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 8f0c01c The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aleksandernsilva
changed the title
aleksandernsilva
force-pushed
the
fix/omni-queue-race-condition
branch
from
3dd2987
to
4f035bc
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #34062 +/- ##
===========================================
- Coverage 75.79% 75.79% -0.01%
===========================================
Files 510 511 +1
Lines 22063 22130 +67
Branches 5385 5394 +9
===========================================
+ Hits 16723 16773 +50
- Misses 4694 4709 +15
- Partials 646 648 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleksandernsilva
force-pushed
the
fix/omni-queue-race-condition
branch
from
2e859f4
to
b009711
Compare
pierre-lehnen-rc
requested changes
Dec 2, 2024
pierre-lehnen-rc
approved these changes
Dec 2, 2024
| } | ||
|
|
||
| async stop() { | ||
| await this.serviceStarter.stop(); |
There was a problem hiding this comment.
Suggested change
| await this.serviceStarter.stop(); | |
| return this.serviceStarter.stop(); |
| @@ -34,20 +46,34 @@ export class OmnichannelQueue implements IOmnichannelQueue { | |||
| this.running = true; | |||
|
|
|||
| queueLogger.info('Service started'); | |||
| return this.execute(); | |||
| await this.execute(); | |||
There was a problem hiding this comment.
Suggested change
| await this.execute(); | |
| return this.execute(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes a bug causing the Omnichannel queue to start more than once due to a race condition. In order to prevent the race condition
settings.watchwas changed tosettings.watchMultiplewhich has a debounce built in.Bug caught through this test omnichannel-livechat-queue-management-autoselection.spec.ts
Introduced here: #33719
Issue(s)
Steps to test or reproduce
Further comments
CONN-429