Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Omnichannel queue starting multiple times due to race condition #34062

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

fix: Omnichannel queue starting multiple times due to race condition #34062

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4f035bc
fix: Omnichannel queue starting multiple times due to race condition
aleksandernsilva Nov 26, 2024
e476a01
chore: changeset
aleksandernsilva Nov 26, 2024
b009711
refactor: Omnichannel queue starting multiple times due to race condi…
aleksandernsilva Nov 29, 2024
47dff9f
refactor: reintroduced settings.watchMultiple
aleksandernsilva Dec 2, 2024
d122ae9
service starter and timeout handler
pierre-lehnen-rc Dec 2, 2024
a4eb5cb
added tests
pierre-lehnen-rc Dec 2, 2024
cf2f824
additional test
pierre-lehnen-rc Dec 2, 2024
46de69a
missing awaits
pierre-lehnen-rc Dec 2, 2024
bc241f6
removed JS privates
pierre-lehnen-rc Dec 2, 2024
8f0c01c
refactor: removed JS privates
aleksandernsilva Dec 2, 2024
f286e03
chore: returns instead of awaits
aleksandernsilva Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-shirts-fold.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixes condition causing Omnichannel queue to start more than once.
6 changes: 1 addition & 5 deletions apps/meteor/server/services/omnichannel/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ export class OmnichannelService extends ServiceClassInternal implements IOmnicha
}

async started() {
settings.watch<boolean>('Livechat_enabled', (enabled) => {
void (enabled && RoutingManager.isMethodSet() ? this.queueWorker.shouldStart() : this.queueWorker.stop());
});

settings.watch<string>('Livechat_Routing_Method', async () => {
settings.watchMultiple(['Livechat_enabled', 'Livechat_Routing_Method'], () => {
this.queueWorker.shouldStart();
});

Expand Down
Loading