Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(lockfile): Switch lockfile to npm-shrinkwrap.json #67

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Apr 5, 2024

Its a try to get dependabot start analyzing the lockfile.
Currently, npm-shrinkwrap.json is not supported officially by dependabot
but the expectation is to get it working by moving to npm-shrinkwrap.json
after the first dependabot PRs are created,

@flovogt
Copy link
Member Author

flovogt commented Apr 5, 2024

Do not merge. Wait until dependabot PRs are created with the usage of package-lock.json

@flovogt flovogt added the blocked Pull requests that are blocked label Apr 5, 2024
Its a try to get dependabot start analyzing the lockfile.
Currently, npm-shrinkwrap.json is not supported officially by dependabot
but the expectation is to get it working by moving to npm-shrinkwrap.json
after the first dependabot PRs are created,
@flovogt flovogt force-pushed the lockfile-use-shringwrap branch from d952a3f to f7e9d05 Compare April 17, 2024 14:06
@flovogt flovogt marked this pull request as ready for review April 17, 2024 14:06
@flovogt flovogt removed the blocked Pull requests that are blocked label Apr 17, 2024
@flovogt flovogt requested a review from RandomByte April 17, 2024 14:07
@flovogt flovogt merged commit 5aa9bc3 into main Apr 17, 2024
17 checks passed
@flovogt flovogt deleted the lockfile-use-shringwrap branch April 17, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants