Small typo fixes + move eslint step to lint job (CI) #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh. I've been misspelling palette the entire time |
|
And yeah I misspelled attachment too. You can go ahead and fix those typos. |
|
@SIsilicon sounds good - wanted to ask first since it could've been on purpose (I've seen misspellings on purpose due to an upstream package being used that contains them so we would need to retrieve those properties with 'misspelled' words) - I can fix that shortly |
PabloAlexis611
force-pushed
the
master
branch
from
c30b783 to
9e3e154
Compare
PabloAlexis611
changed the title
|
Re-opening PR without merge conflicts |
|
@SIsilicon ready for review, build failure still present (same as seen in: #232) (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read over the contributing guidelines - I don't think I've to do anything else.
There's an optional commit I can revert if needed at: c30b783.
I also saw one (possible?) typo in some variables -
pallete(which could bepalette- unsure if that's just an English variation of the word). Also found interesting that in thesrc/server/modules/region_buffer.tsfile there's this Block permutation state being retrieved, calledattachement? 🤔 which is actually a French word and not English