Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-6035: Dashboard: Initial design implementation #1719

Open
wants to merge 12 commits into
base: SHS-5913_Dashboard-initiative
Choose a base branch
from

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Jan 16, 2025

Summary

Implementation of initial design

Need Review By (Date)

01/24

Urgency

medium

Steps to Test

  1. Go to admin/structure/dashboard
  2. Add a dashboard and enable it (please try to add more than one to see both of them look as expected)
  3. Edit the layout of the dasboard
  4. Add 1col, 2col 3col and 4 col
  5. Add custom block or any block
  6. Save it
  7. Now go to /admin/dashboard and also check the preview
  8. Confirm the general design looks according to what you see in the screenshot below and the Figma design. Just a heads up the way the content is design for each block will be implemented when creating each block in future tickets. This is more a general design of how everything is displayed and the color palette.

image

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@mariannuar mariannuar changed the base branch from develop to SHS-5913_Dashboard-initiative January 16, 2025 18:30
@ahughes3 ahughes3 temporarily deployed to Tugboat January 16, 2025 18:32 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat January 16, 2025 21:56 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat January 16, 2025 22:31 Destroyed
@mariannuar mariannuar self-assigned this Jan 16, 2025
@mariannuar mariannuar marked this pull request as ready for review January 16, 2025 22:33
@ahughes3 ahughes3 temporarily deployed to Tugboat January 17, 2025 21:00 Destroyed
@mariannuar mariannuar removed the request for review from callinmullaney January 21, 2025 17:44
@ahughes3 ahughes3 temporarily deployed to Tugboat January 21, 2025 19:11 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat January 21, 2025 19:20 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat January 21, 2025 19:27 Destroyed
@mariannuar mariannuar requested a review from cienvaras January 21, 2025 20:42
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Looks good, just some small fixes needed.

@mariannuar mariannuar requested a review from cienvaras January 24, 2025 15:29
@mariannuar
Copy link
Collaborator Author

@cienvaras This is ready for review again!

Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar LGTM!

@ahughes3 Ready for you to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants