-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-6035: Dashboard: Initial design implementation #1719
Open
mariannuar
wants to merge
12
commits into
SHS-5913_Dashboard-initiative
Choose a base branch
from
shs-6035--dashboard-initial-design-implementation
base: SHS-5913_Dashboard-initiative
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SHS-6035: Dashboard: Initial design implementation #1719
mariannuar
wants to merge
12
commits into
SHS-5913_Dashboard-initiative
from
shs-6035--dashboard-initial-design-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariannuar
changed the base branch from
develop
to
SHS-5913_Dashboard-initiative
January 16, 2025 18:30
11 tasks
…nly to the dashboard
cienvaras
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Looks good, just some small fixes needed.
docroot/themes/humsci/su_humsci_gin_admin/su_humsci_gin_admin.libraries.yml
Outdated
Show resolved
Hide resolved
docroot/themes/humsci/su_humsci_gin_admin/su_humsci_gin_admin.theme
Outdated
Show resolved
Hide resolved
docroot/themes/humsci/su_humsci_gin_admin/su_humsci_gin_admin.theme
Outdated
Show resolved
Hide resolved
@cienvaras This is ready for review again! |
cienvaras
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar LGTM!
@ahughes3 Ready for you to review.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of initial design
Need Review By (Date)
01/24
Urgency
medium
Steps to Test
/admin/dashboard
and also check the previewReview Tasks
Backend / Functional Validation
Code
snake_case
and notcamelCase
?Code security
General