D8CORE-6970 | @jdwjdwjdw | Update local footer headlines #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
241
to
257
| .su-local-footer__list-heading { | ||
| font-size: 18px; | ||
| line-height: 140%; | ||
| } | ||
|
|
||
| .stanford-local-footer { | ||
| &.su-wysiwyg-text { | ||
| h2 { | ||
| font-size: 18px; | ||
| line-height: 140%; | ||
| } | ||
|
|
||
| h3, | ||
| h4, | ||
| h5 { | ||
| font-size: 16px; | ||
| line-height: 140%; |
There was a problem hiding this comment.
@jdwjdwjdw If you could please just convert the font sizes from px to rem unit, eg, 18px = 1.8rem, this should be good to go. We're trying to avoid px units since those doesn't scale up if user changes their font size setting in the browsers.
There was a problem hiding this comment.
@yvonnetangsu sounds good, thanks - should be good to re-review now.
yvonnetangsu
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
This should be GTG - thanks @jdwjdwjdw ! I'll add a patch label and merge
|
Release is out @jdwjdwjdw 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
h2's in the local footer to be 18px, withh3-h5updated to16px.Needed By (Date)
Urgency
Steps to Test
/admin/config/system/local-footerand fill out all of the fields to match the Amptesting site. Save page and navigate to a page you can view the local footer.h2's in the local footer (including theContent Blockssection) are the same size (18px) and h3-h5's are 16px.Associated Issues and/or People