Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-6970 | @jdwjdwjdw | Update local footer headlines #926

Merged
merged 7 commits into from
Oct 19, 2023
Merged

D8CORE-6970 | @jdwjdwjdw | Update local footer headlines #926

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3e5860
Update local footer headlines
jdwjdwjdw Oct 3, 2023
434d861
Merge branch 'master' into A11y/D8CORE-6970--local-footer-headlines
sherakama Oct 6, 2023
8bd5a85
Merge branch 'master' into A11y/D8CORE-6970--local-footer-headlines
sherakama Oct 6, 2023
3e1d427
Code Climate fixups
jdwjdwjdw Oct 19, 2023
1f7f94c
Merge branch 'master' into A11y/D8CORE-6970--local-footer-headlines
jdwjdwjdw Oct 19, 2023
870bcda
Update dist
jdwjdwjdw Oct 19, 2023
6048087
Update font-size to rems
jdwjdwjdw Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/dist/css/decanter.css
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 17 additions & 1 deletion core/src/scss/components/local-footer/_local-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,13 +236,29 @@
}


// List heading element styles.
// List and content block heading element styles.
// ------------------------------------------------
.su-local-footer__list-heading {
font-size: 18px;
line-height: 140%;
}

.stanford-local-footer {
&.su-wysiwyg-text {
h2 {
font-size: 18px;
line-height: 140%;
}

h3,
h4,
h5 {
font-size: 16px;
line-height: 140%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdwjdwjdw If you could please just convert the font sizes from px to rem unit, eg, 18px = 1.8rem, this should be good to go. We're trying to avoid px units since those doesn't scale up if user changes their font size setting in the browsers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yvonnetangsu sounds good, thanks - should be good to re-review now.

}
}
}

// Common styles for address and links.
// ------------------------------------------------
.su-local-footer__address,
Expand Down