Update TW to v3.4.1 and nvmrc to 20 #942
Conversation
| /** | ||
| * Use this directive to control where Tailwind injects the responsive | ||
| * variations of each utility. | ||
| * | ||
| * If omitted, Tailwind will append these classes to the very end of | ||
| * your stylesheet by default. | ||
| */ | ||
| @tailwind variants; |
There was a problem hiding this comment.
Removing this one because we no longer need this line
https://tailwindcss.com/docs/installation
| /** | ||
| * Note: in TW v3.4.0, the *: variant is added for targeting direct children | ||
| * https://github.com/tailwindlabs/tailwindcss/pull/12551 | ||
| * Leaving these in for now for backwards compatibility. | ||
| */ |
There was a problem hiding this comment.
Leaving in our current custom children: variant because we used that on every site.
There was a problem hiding this comment.
Yeah, and they are different.
Children use the direct child selector to select any immediate element > * which scopes that at one level
I'd have to test to confirm but using the wildcard selector * without the direct child selector opens up the selectivity scope to all the levels
There was a problem hiding this comment.
Oh don't worry @sherakama , Tailwind actually make the *: variant only select direct children so it's actually equivalent to > *, same as our children: variant. Some people were commenting on whether it's good idea for them to pick the * 😂
There was a problem hiding this comment.
Oh, I just read tailwindlabs/tailwindcss#12551
* is a direct child selector 🤦
That difference isn't obvious with this syntax but it makes sense after reading the thread.
There was a problem hiding this comment.
Yeah it could be a bit confusing because of the * 😅
|
@sherakama I'm testing this branch in this Campaign preview here: |
yvonnetangsu
added
minor
yvonnetangsu
requested review from
iamrentman and
rebeccahongsf
and removed request for
iamrentman
|
Tagging @rebeccahongsf as a FYI. TW 3.4.0 has some new features |
|
Ok merging. Thanks for the review! |
READY FOR REVIEW
Summary
Needed By (Date)
Urgency
Steps to Test
Tailwind 3.4.1 ood-giving-campaign#189
https://deploy-preview-189--giving-campaign.netlify.app/