Tailwind 3.4.1 #189
Merged
Tailwind 3.4.1 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ildren (first level in this batch)
✅ Deploy Preview for giving-campaign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yvonnetangsu
commented
Jan 11, 2024
package.json
Outdated
| @@ -54,7 +54,7 @@ | |||
| "@types/react": "^18.2", | |||
| "@types/react-dom": "^18.2", | |||
| "autoprefixer": "^10.4.16", | |||
| "decanter": "^7.1.2", | |||
| "decanter": "github:SU-SWS/decanter#tw-3.4.1", | |||
There was a problem hiding this comment.
I'll replace with latest version of decanter once this branch is merged.
sherakama
reviewed
Jan 11, 2024
| @@ -1,6 +1,6 @@ | |||
| export const wrapper = 'mr-0 au-ml-auto flex-col lg:flex-row'; | |||
| export const contentWrapper = 'lg:rs-pr-9 ml-0'; | |||
| export const heading = '2xl:whitespace-pre-line -mt-01em rs-mb-2 xl:max-w-1200'; | |||
| export const body = 'max-w-[50ch] rs-mb-3 children:children:leading-snug'; | |||
| export const body = 'max-w-[50ch] rs-mb-3 *:*:leading-snug'; | |||
sherakama
reviewed
Jan 11, 2024
| @@ -6,7 +6,7 @@ export const imageWrapper = 'overflow-hidden aspect-w-1 aspect-h-2'; | |||
| export const info = 'rs-px-1 pb-150 absolute w-full h-full bottom-0 left-0 mb-0'; | |||
| export const heading = 'mb-02em mt-auto'; | |||
|
|
|||
| export const cardContent = 'absolute w-full h-full top-0 left-0 px-20 py-30 3xl:py-48 3xl:px-36 aria-hidden:opacity-0 opacity-100 backdrop-blur-sm transition-opacity duration-500 bg-gradient-to-b from-gc-black/60 to-gc-black/90 gc-changemaker children:children:children:!mb-1em'; | |||
| export const cardContent = 'absolute w-full h-full top-0 left-0 px-20 py-30 3xl:py-48 3xl:px-36 aria-hidden:opacity-0 opacity-100 backdrop-blur-sm transition-opacity duration-500 bg-gradient-to-b from-gc-black/60 to-gc-black/90 gc-changemaker *:*:*:!mb-1em'; | |||
There was a problem hiding this comment.
To get to those WYSIWYG elements 😂
|
I rate this PR 10 *s |
lol thanks for reviewing 😂 ! Want to approve the Decanter PR also? I used the minor version tag because the TW upgrade was also a minor version. |
|
I'm going to push this through since you already reviewed @sherakama 🤠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review Tasks
Setup tasks and/or behavior to test