Skip to content

Commit

Permalink
8.1.14
Browse files Browse the repository at this point in the history
- D8CORE-4341: changing display from flex to grid (#143) (0936dd3)
  • Loading branch information
pookmish authored Jun 11, 2021
2 parents 744595f + c7e5ed8 commit 034bdc1
Show file tree
Hide file tree
Showing 7 changed files with 55 additions and 14 deletions.
7 changes: 5 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@ version: 2
## Defines images and working directory.
defaults: &defaults
docker:
- image: pookmish/drupal8ci:pcov
- image: pookmish/drupal8ci:latest
- image: selenium/standalone-chrome:latest
- image: mariadb:10.3
- image: circleci/mysql:5.7
environment:
MYSQL_DATABASE: drupal
MYSQL_USER: drupal
MYSQL_PASSWORD: drupal
MYSQL_ALLOW_EMPTY_PASSWORD: 1
working_directory: /var/www/html

Expand Down
20 changes: 14 additions & 6 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,28 @@
- How critical is this PR on a 1-10 scale? Also see [Severity Assessment](https://stanfordits.atlassian.net/browse/D8CORE-1705).
- E.g., it affects one site, or every site and product?

# Urgency
- How urgent is this? (Normal, High)

# Review Tasks

## Setup tasks and/or behavior to test

1. Check out this branch
2. Navigate to...
3. Verify...
2. Rebuild Cache and import config `drush cr ; drush ci`
3. Navigate to...
4. Verify...

### Site Configuration Sync

- Is there a config:export in this PR that changes the config sync directory?

## Front End Validation
- [ ] Is the markup using the appropriate semantic tags and passes HTML validation?
- [ ] Cross-browser testing has been performed?
- [ ] Automated accessibility scans performed?
- [ ] Manual accessibility tests performed?
- [ ] Design is approved by @ user?
- [ ] HTML validation: Is the markup using the appropriate semantic tags and [passes validation](https://validator.w3.org/nu/)? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
- [ ] Cross-browser testing: Has been performed? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
- [ ] Automated accessibility: Scans performed? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
- [ ] Manual accessibility: Manually tested? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?

## Backend / Functional Validation
### Code
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Stanford News

8.x-1.14
--------------------------------------------------------------------------------
_Release Date: 2021-06-11_

- D8CORE-4341: changing display from flex to grid (#143) (0936dd3)

8.x-1.13
--------------------------------------------------------------------------------
_Release Date: 2021-05-07_
Expand Down
2 changes: 1 addition & 1 deletion dist/css/stanford_person.views.css

Large diffs are not rendered by default.

30 changes: 27 additions & 3 deletions lib/scss/stanford_person.views.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,40 @@
}
}

.su-person-grid-view,
.section-grid-view {
.main-region {
@include grid-media-min(xl) {
@include modular-spacing('padding-left', 2);
}
}
}

// Grid set up
.stanford-people-grid {

// Changing to a Css Grid
.flex-container {
display: grid;
grid-template-columns: repeat(3, 1fr);
grid-column-gap: 1em;

@include grid-media-max('xs') {
display: unset;
}

> .views-col {
max-width: 100%;
}
}

.views-row {
@include modular-spacing('margin-bottom', 6);

.views-col {
@include modular-spacing('margin-right', 3);

// In xs display the people have a layout of image and text to the right.
@include grid-media-max('xs') {
@include grid-media-max('lg') {
@include modular-spacing('margin-bottom', 4);

.views-field-su-person-photo {
Expand All @@ -49,6 +72,8 @@

color: $su-color-bright-red;
text-decoration: none;
word-break: break-word;
word-wrap: break-word;

&:focus,
&:hover {
Expand Down Expand Up @@ -111,7 +136,6 @@
}
}


// Removing extra space for a Person list in a paragraph
.paragraph {
.stanford-people-grid {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ type: module
description: 'Migration support for importing of profile information from stanford.edu.'
core_version_requirement: '^8.8 || ^9'
package: Stanford
version: 8.x-1.13
version: 8.x-1.14
dependencies:
- 'config_pages:config_pages'
- 'drupal:migrate'
Expand Down
2 changes: 1 addition & 1 deletion stanford_person.info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ type: module
description: 'A person bio and supporting information content type'
core_version_requirement: ^8 || ^9
package: Stanford
version: 8.x-1.13
version: 8.x-1.14
dependencies:
- allowed_formats:allowed_formats
- auto_entitylabel:auto_entitylabel
Expand Down

0 comments on commit 034bdc1

Please sign in to comment.