Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user setting to determine if the IdP should force use of mfa when available #653

Merged
merged 14 commits into from
Aug 12, 2024

Conversation

johanlundberg
Copy link
Member

No description provided.

Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

src/eduid/webapp/idp/tests/test_SSO.py Outdated Show resolved Hide resolved
src/eduid/webapp/idp/tests/test_login.py Outdated Show resolved Hide resolved
src/eduid/webapp/idp/tests/test_SSO.py Show resolved Hide resolved
Copy link
Contributor

@helylle helylle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@helylle helylle merged commit 702bd50 into main Aug 12, 2024
6 of 9 checks passed
@helylle helylle deleted the lundberg_idp_optional_mfa branch August 12, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants