Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user setting to determine if the IdP should force use of mfa when available #653

Merged
merged 14 commits into from
Aug 12, 2024
Merged

Use user setting to determine if the IdP should force use of mfa when available #653

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6e0e1b2
check user settings if mfa should be forced for user
johanlundberg Jun 25, 2024
74e0396
add support for mfa in idp tests
johanlundberg Jun 25, 2024
ed22f95
refactor response checks
johanlundberg Jun 26, 2024
5b028f9
more descriptive argument for a user setting
johanlundberg Jun 26, 2024
cd64a20
add tests for mfa logins
johanlundberg Jun 26, 2024
4f2ba8f
nitpicking
johanlundberg Jun 26, 2024
7f8f84f
Merge branch 'main' into lundberg_idp_optional_mfa
johanlundberg Jun 27, 2024
6cf1645
refactor login tests to use shared _check_login_result
johanlundberg Jun 27, 2024
9a1fce8
make reformat
johanlundberg Jun 27, 2024
2c12c2f
Merge branch 'lundberg_user_settings' into lundberg_idp_optional_mfa
johanlundberg Jun 28, 2024
f0fdbdc
settings -> preferences
johanlundberg Jun 28, 2024
33a43d0
Merge branch 'main' into lundberg_idp_optional_mfa
johanlundberg Aug 9, 2024
ba8c7ab
mod_data already in data at this point
johanlundberg Aug 9, 2024
5667250
fixes after review
johanlundberg Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/eduid/webapp/idp/mfa_action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ def need_security_key(user: IdPUser, ticket: LoginContext) -> bool:
logger.debug("User has no FIDO credentials, no extra requirement for MFA this session imposed")
return False

if user.preferences.always_use_security_key is False:
logger.debug("User has not forced MFA, no extra requirement for MFA this session imposed")
return False

for cred_key in ticket.pending_request.credentials_used:
credential: Optional[Credential]
if cred_key in ticket.pending_request.onetime_credentials:
Expand Down
Loading
Loading