Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian support on RMT #1078

Merged
merged 53 commits into from
Apr 10, 2024
Merged

Debian support on RMT #1078

merged 53 commits into from
Apr 10, 2024

Conversation

ngetahun
Copy link
Contributor

Description

Please describe your change and provide as much context as possible.

Fixes # (issue)

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have verified that my code follows RMT's coding standards with rubocop.
  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • RMT's test coverage remains at 100%.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Other Notes

Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.

@SUSE SUSE deleted a comment from suse-tests-fail Jan 31, 2024
@SUSE SUSE deleted a comment from suse-tests-fail Feb 2, 2024
@SUSE SUSE deleted a comment from suse-tests-fail Feb 7, 2024
ngetahun
ngetahun commented Apr 2, 2024
View reviewed changes
package/obs/rmt.conf Outdated Show resolved Hide resolved
ngetahun and others added 25 commits April 10, 2024 14:18
@ngetahun @felixsch
WIP: Add ssl parsing config keys
75d33f6
@felixsch
Revert "Revert "[1/x] Prepare code sprint and implement repository ty…
2d4fe72 
…pe detection""
@ngetahun @felixsch
WIP: Refactoring mirroring and add debian mirror class
f1a77ba
@felixsch
Added more tests for base mirroing class
7a3f173
@likhitha77 @felixsch
Parse debian release file
f512b7f
@likhitha77 @felixsch
Refactor GPG check and implement debian metadata mirroring
1cf3929
@likhitha77 @felixsch
Rubocop and minor test fixes
ec07a7a
@ngetahun @felixsch
WIP: Refactoring mirroring and add debian mirror class
9745871
@felixsch
Added more tests for base mirroing class
c92a70d
@likhitha77 @felixsch
Parse debian release file
20b3bdf
@likhitha77 @felixsch
Refactor GPG check and implement debian metadata mirroring
c1ebdfc
@likhitha77 @felixsch
Rubocop and minor test fixes
6b1636e
@felixsch
Parse package list files
5392c52
@likhitha77 @felixsch
Debian package deduplication check + refactor FileReference
e7f25f7
@likhitha77 @felixsch
Moving Debian files to correct location from temp dir
8825c33
@likhitha77 @felixsch
minor spec fix
e8012bb
@felixsch
Finalize tests and make rubocop happy :>
fd0b606
@likhitha77 @felixsch
Adding tests to improve coverage
b9aecd6
@ngetahun @felixsch
Refactoring: Moved suma product tree mirroring into a separate class
f9426a4
@ngetahun @felixsch
Rerfactor suma product tree mirroring in repomd and mirror classes
30a31fa
@ngetahun @felixsch
Fix broken specs
b737406
@ngetahun @felixsch
refactor repomd mirror
906dcfb 
extract license mirroring
@ngetahun @felixsch
Complete remaining license mirror specs
1512346
@ngetahun @felixsch
Cleanup files
fcda31f
@likhitha77 @felixsch
Refactor repomd mirror_metadata
d584789
ngetahun and others added 22 commits April 10, 2024 14:26
@ngetahun @felixsch
Remove obsolete VCR files
763fcd2
@lcaparroz @felixsch
Implements RMT::Mirror repository mirroring
7a0b2f6
@felixsch
Remove unused config option verify_rpm_checksums
f81c7be
@felixsch
Cleanup tests in cli/mirror and started refreshing import/export
5108f36
@felixsch
Export now is using the new mirroring classes.
f2274f9 
 * Enhanced tests in cli/mirror
@felixsch
Make import logic use our new implemenations
21999d2 
 * Correctly detect repository type when importing from a local source
@felixsch
Cleanup naming, adding missing tests, fix renames
df66d1a
@likhitha77 @felixsch
Fixing updates.license issue
3b48f94
@likhitha77 @felixsch
Adding tests for cli/base
13949f5
@ngetahun @felixsch
Extend mirroring test to authorized repositories
64fee8f
@likhitha77 @felixsch
Removing repomd from rubocop exceptions
55c8fb4
@likhitha77 @felixsch
Mirroring nested debian repos
ceb41b1
@ngetahun @felixsch
Improve log messages
c700742 
Increase test coverage

Fix variable naming
@felixsch
I'm a not working commit!
a934cec
@lcaparroz @felixsch
Fix cache_dir for nested Debian repos
796eb01
@ngetahun @felixsch
Update changelog and version
b1ff16d
@felixsch
Fixed linting and added comments
8aa785a
@felixsch
Remove SSL mariadb connection options
0c765a3
@ngetahun @felixsch
Fix regex issue, require Packages.gz files when downloading
c92bc00 
Remove uncovered files from coverage report
@ngetahun @felixsch
Revert converage filtering
9d22217
@ngetahun @felixsch
Cleanup unmerged config changes
88a8817
@felixsch
Switch to repomd_parser 1.1.0 interface
e326e83 
With the update to 1.1.0 the library interface changed and this needed
to be updated.
@felixsch felixsch force-pushed the rmt_deb_codesprint branch from 77b62dd to e326e83 Compare April 10, 2024 12:47
felixsch
felixsch approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@felixsch felixsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

How I tested this pullrequest:

  • Ran rmt-cli mirror with:
    • Tested mirroring bz2 compressed repomd repositories
    • Tested regular repomd repositories
    • Tested custom repositories
    • Tested mirroring SUMA Tools debian repository

As always, if you think I missed something please let me know!🚀

@felixsch felixsch merged commit cedffa3 into master Apr 10, 2024
3 checks passed
@felixsch felixsch deleted the rmt_deb_codesprint branch April 10, 2024 14:59
@Adnilson Adnilson mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixsch felixsch felixsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ngetahun @felixsch @likhitha77 @lcaparroz @mssola