Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG-1410: change position so tooltip is displayed in firefox #1300

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

hallieswan
Copy link
Contributor

AG-1410_firefox.mov

tooltipPosition="top"
tooltipPosition="left"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Firefox, the tooltip would appear on top of the button when the screen was very wide, but not when the screen was narrow. I suspect that the bug was related to how PrimeNG calculates the tooltip position when the tooltip is close to the edge of the screen. Moving the tooltip to the left of the button ensures that the tooltip is shown even when the screen is narrow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@hallieswan hallieswan marked this pull request as ready for review April 24, 2024 17:56
@hallieswan hallieswan requested a review from sagely1 April 24, 2024 17:56
@hallieswan hallieswan merged commit c80b03f into Sage-Bionetworks:develop Apr 24, 2024
3 checks passed
@hallieswan hallieswan deleted the AG-1410 branch April 24, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants