Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG-1410: change position so tooltip is displayed in firefox #1300

Merged
merged 1 commit into from
Apr 24, 2024
+1 −1
Merged

AG-1410: change position so tooltip is displayed in firefox #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ <h1 class="gct-heading h2">Gene Comparison Tool</h1>
'). You must unpin some genes before you can pin more.'
: 'Add all matching genes to Pinned list'
"
tooltipPosition="top"
tooltipPosition="left"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Firefox, the tooltip would appear on top of the button when the screen was very wide, but not when the screen was narrow. I suspect that the bug was related to how PrimeNG calculates the tooltip position when the tooltip is close to the edge of the screen. Moving the tooltip to the left of the button ensures that the tooltip is shown even when the screen is narrow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

tooltipStyleClass="tooltip"
>
<svg-icon name="pin" customClass="two-tone"></svg-icon>
Expand Down
Loading