Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETL-575] Pass SkipDestinationValidation=True #88

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[ETL-575] Pass SkipDestinationValidation=True #88

merged 2 commits into from
Oct 31, 2023

Conversation

BryanFauble
Copy link
Contributor

In the lambda function to add event notifications pass SkipDestinationValidation=True in the put_bucket_notification_configuration call

@BryanFauble BryanFauble requested a review from a team as a code owner October 30, 2023 20:18
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:21 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:21 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:29 — with GitHub Actions Inactive
philerooski
philerooski approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@philerooski philerooski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your log messages are f-strings but you don't use the f-string syntax.

Do you need to add a space after "for" or does create_formatted_message include white space at the beginning of its message?

@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:34 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:44 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:44 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:44 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:44 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:48 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:48 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 20:57 — with GitHub Actions Inactive
@BryanFauble BryanFauble temporarily deployed to develop October 30, 2023 21:01 — with GitHub Actions Inactive
@BryanFauble BryanFauble merged commit 0b73e55 into main Oct 31, 2023
14 checks passed
@BryanFauble BryanFauble deleted the etl-575-skip-dest-valid branch October 31, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philerooski philerooski philerooski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryanFauble @philerooski