Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL-575] Pass SkipDestinationValidation=True #88

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[ETL-575] Pass SkipDestinationValidation=True #88

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4df8a05
Pass SkipDestinationValidation=True
BryanFauble Oct 30, 2023
798a026
Code review feedback
BryanFauble Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/lambda_function/s3_event_config/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,17 @@ def add_notification(
update_required = True

if update_required:
logger.info(
f"Put request started to add a NotificationConfiguration for"
+ create_formatted_message(bucket, destination_type, destination_arn)
)
existing_bucket_notification_configuration[
f"{destination_type}Configurations"
] = existing_notification_configurations_for_type
s3_client.put_bucket_notification_configuration(
Bucket=bucket,
NotificationConfiguration=existing_bucket_notification_configuration,
SkipDestinationValidation=True,
)
logger.info(
f"Put request completed to add a NotificationConfiguration for"
Expand Down Expand Up @@ -318,9 +323,14 @@ def delete_notification(
f"{destination_type}Configurations"
]

logger.info(
f"Delete request started to remove a NotificationConfiguration for"
+ create_formatted_message(bucket, destination_type, destination_arn)
)
s3_client.put_bucket_notification_configuration(
Bucket=bucket,
NotificationConfiguration=existing_bucket_notification_configuration,
SkipDestinationValidation=True,
)
logger.info(
f"Delete request completed to remove a NotificationConfiguration for"
Expand Down
Loading