PORTALS-3312: New Portal feature highlights component #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianamcc
commented
Dec 5, 2024
...ages/synapse-react-client/src/components/PortalFeatureHighlights/PortalFeatureHighlights.tsx
Outdated
Show resolved
Hide resolved
jay-hodgson
reviewed
Dec 6, 2024
nickgros
reviewed
Dec 6, 2024
Comment on lines
32
to
37
| <Typography | ||
| component="span" | ||
| sx={{ fontWeight: 'bold', color: 'primary.main' }} | ||
| > | ||
| CAVATICA | ||
| </Typography> |
There was a problem hiding this comment.
Is this supposed to be a link?
There was a problem hiding this comment.
Confirmed with Adam this should link to the Cavatica website
nickgros
reviewed
Dec 6, 2024
Comment on lines
24
to
25
| import analyzetheclouds from '@sage-bionetworks/synapse-portal-framework/components/elportal/assets/analyzetheclouds.png' | ||
| import computationaltools from '@sage-bionetworks/synapse-portal-framework/components/elportal/assets/computationaltools.png' |
There was a problem hiding this comment.
move these assets to the elportal project if they are only used in the elportal
There was a problem hiding this comment.
I am a bit curious about how these imports work. I would expect Vite would need you to have the ?url suffix, but maybe what you have is fine
There was a problem hiding this comment.
This has been working for me! I assume Vite is configured to handle image assets correctly?
nickgros
reviewed
Dec 6, 2024
nickgros
reviewed
Dec 6, 2024
...ages/synapse-react-client/src/components/PortalFeatureHighlights/PortalFeatureHighlights.tsx
Outdated
Show resolved
Hide resolved
nickgros
reviewed
Dec 6, 2024
...ages/synapse-react-client/src/components/PortalFeatureHighlights/PortalFeatureHighlights.tsx
Outdated
Show resolved
Hide resolved
nickgros
reviewed
Dec 6, 2024
...ages/synapse-react-client/src/components/PortalFeatureHighlights/PortalFeatureHighlights.tsx
Outdated
Show resolved
Hide resolved
nickgros
reviewed
Dec 6, 2024
...ages/synapse-react-client/src/components/PortalFeatureHighlights/PortalFeatureHighlights.tsx
Outdated
Show resolved
Hide resolved
kianamcc
force-pushed
the
PORTALS-3312
branch
from
2ad7899 to
fbc0192
Compare
kianamcc
added
the
chromatic
nickgros
approved these changes
Dec 13, 2024
Comment on lines
+29
to
+32
| gridTemplateAreas: { | ||
| xs: `'image' 'content'`, | ||
| lg: reverseOrder ? `'content image'` : `'image content'`, | ||
| }, |
There was a problem hiding this comment.
nice use of gridTemplateAreas, it's very clear how the layout is switching between sizes and reverseOrder state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://sagebionetworks.jira.com/browse/PORTALS-3312
Desktop:
Mobile:
