-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PORTALS-3312: New Portal feature highlights component #1437
Merged
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
94cb381
portal feature highlights wip
kianamcc 4d49cc6
portalfeaturehighlights wip
kianamcc a579513
tests
kianamcc 69c8ea1
Merge branch 'main' into PORTALS-3312
kianamcc b4b2b06
more mobile responsiveness, homespace for elcontributeyourdata component
kianamcc 3ecad20
typo
kianamcc 65c121c
Merge branch 'main' into PORTALS-3312
kianamcc 4939a50
update to absolute paths
kianamcc ec92795
review changes wip
kianamcc c8f08ef
padding cleanup, direction instead of order
kianamcc d702de2
cleanup, wip
kianamcc ce905ae
Cavatica link
kianamcc fbc0192
fix typecheck error
kianamcc 7e4f3e6
“mergingg”
kianamcc 95c5af0
styling cleanup
kianamcc 3f2d813
unused import
kianamcc 35a34c0
styling updates, customized grid
kianamcc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
...e-react-client/src/components/PortalFeatureHighlights/PortalFeatureHighlights.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
...apse-react-client/src/components/PortalFeatureHighlights/PortalFeatureHighlights.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice use of gridTemplateAreas, it's very clear how the layout is switching between sizes and
reverseOrder
state