add cases in OMFReader #2061
Merged
add cases in OMFReader #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wpotrzebowski
added
the
Discuss At The Call
krzywon
reviewed
Jun 7, 2022
There was a problem hiding this comment.
A suggestion was made in the conference call today by @wpotrzebowski to add at least one example data set and unit tests for the latest format version. I second that suggestion.
|
@dehoni have the suggestion to the code change been addressed? |
|
@dehoni will take a look on failing tests |
All changes have been implemented. |
wpotrzebowski
removed
the
Discuss At The Call
wpotrzebowski
approved these changes
Jul 4, 2022
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.