Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials open in browser to avoid PDF failure #2927

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

lucas-wilkins
Copy link
Contributor

The links to tutorials from the document editor don't work because they're PDF files, and it can't open them

I've changed the tutorial opening behaviour to back to just opening a web link as it did before.

I've opened an issue for updating the editor to handle PDFs - #2926

fixes #2908

@lucas-wilkins lucas-wilkins added the SasView 6.0.0 Required for 6.0.0 release label Jul 2, 2024
@lucas-wilkins lucas-wilkins requested a review from krzywon July 2, 2024 09:07
@lucas-wilkins lucas-wilkins changed the title Changed to open in browser Tutorials open in browser to avoid PDF failure Jul 2, 2024
@lucas-wilkins lucas-wilkins linked an issue Jul 2, 2024 that may be closed by this pull request
Copy link
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested actions/runs/9758139744 on W10/x64.

Help > Tutorials does spawn a new window in the default browser but the links still do not open (but do work if you copy/paste them into a browser tab or file explorer).

Help > Documentation > User Documentation > Working with SasView > Tutorials still uses the Documentation Viewer and again the links do not open.

I have tried clearing my browser (Chrome) cache and even resetting. Made no difference.

Others should see what behaviour they get on different platforms/browsers.

@lucas-wilkins lucas-wilkins added the Discuss At The Call Issues to be discussed at the fortnightly call label Jul 2, 2024
@butlerpd
Copy link
Member

butlerpd commented Jul 2, 2024

problem if one tries to link to pdf from the documentation itself. Maybe remove from documentation itself? Needs some testing? @smk78 and @lucas-wilkins to discuss. Others should try installer.

Copy link
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested actions build 9765628806 on W10/x64

Help > Tutorials now opens a browser page at https://www.sasview.org/docs/user/tutorial.html and so the links now work.

A separate PR will need to address the route by Help > Documentation > User Documentation > Working with SasView > Tutorials

@smk78 smk78 merged commit 9009914 into release_6.0.0 Jul 3, 2024
28 checks passed
@smk78 smk78 deleted the 2908-links-in-tutorialrst-dont-resolve branch July 3, 2024 14:19
@lucas-wilkins
Copy link
Contributor Author

@smk78 That link hasn't been removed has it?

@smk78
Copy link
Contributor

smk78 commented Jul 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discuss At The Call Issues to be discussed at the fortnightly call SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in tutorial.rst don't resolve
3 participants