-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorials open in browser to avoid PDF failure #2927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested actions/runs/9758139744 on W10/x64.
Help > Tutorials does spawn a new window in the default browser but the links still do not open (but do work if you copy/paste them into a browser tab or file explorer).
Help > Documentation > User Documentation > Working with SasView > Tutorials still uses the Documentation Viewer and again the links do not open.
I have tried clearing my browser (Chrome) cache and even resetting. Made no difference.
Others should see what behaviour they get on different platforms/browsers.
problem if one tries to link to pdf from the documentation itself. Maybe remove from documentation itself? Needs some testing? @smk78 and @lucas-wilkins to discuss. Others should try installer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested actions build 9765628806 on W10/x64
Help > Tutorials now opens a browser page at https://www.sasview.org/docs/user/tutorial.html and so the links now work.
A separate PR will need to address the route by Help > Documentation > User Documentation > Working with SasView > Tutorials
@smk78 That link hasn't been removed has it? |
I'm dealing with them now in https://github.com/SasView/sasview/tree/2926-Fix-broken-tutorial-links-in-Working-with-SasView |
The links to tutorials from the document editor don't work because they're PDF files, and it can't open them
I've changed the tutorial opening behaviour to back to just opening a web link as it did before.
I've opened an issue for updating the editor to handle PDFs - #2926
fixes #2908