Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v6 tutorials #3123

Closed
wants to merge 174 commits into from
Closed

Add v6 tutorials #3123

wants to merge 174 commits into from

Conversation

smk78
Copy link
Contributor

@smk78 smk78 commented Oct 15, 2024

Description

Adds the v6 tutorials to the release branch.

NB: the corresponding v5 tutorials in the folder should be removed.

wpotrzebowski and others added 30 commits June 28, 2024 15:02
…installers need to install some packages before others
…new plots from getting the transforms of previous plots
…sure teh uninstall name is unique from version to version
…e formula includes the density and is incomplete
Check successful launch of sasview on CI (linux)
@smk78 smk78 added Documentation Concerns documentation SasView 6.0.0 Required for 6.0.0 release labels Oct 15, 2024
@smk78 smk78 added this to the SasView 6.0.0 milestone Oct 15, 2024
@smk78 smk78 requested a review from krzywon October 15, 2024 16:26
@lucas-wilkins
Copy link
Contributor

@smk78 I don't think this PR does what you want it to. Says merge release_6.0.0 into main.

Copy link
Contributor

@lucas-wilkins lucas-wilkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comment!!!!

@krzywon
Copy link
Contributor

krzywon commented Oct 16, 2024

The tutorials are already in the release_6.0.0 branch. @smk78 pushed them directly into it. This PR can likely be closed.

@smk78
Copy link
Contributor Author

smk78 commented Oct 17, 2024

The tutorials are already in the release_6.0.0 branch. @smk78 pushed them directly into it. This PR can likely be closed.

But don't they also need to go into main?

@krzywon
Copy link
Contributor

krzywon commented Oct 17, 2024

But don't they also need to go into main?

They will be. Once v6 is finalized, we will merge the entire release branch back into main. Until then, we can wait on this.

jamescrake-merani and others added 2 commits October 18, 2024 09:21
…aph-causes-it-to-go-blank

3127 adding custom text to a graph causes it to go blank
@krzywon krzywon closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Concerns documentation SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.