Pushing test for Persistent XSS in HTML #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Test | ||
| public void testGetVulnerablePayloadLevel7() { | ||
| Map<String, String> queryParams = new HashMap<>(); |
There was a problem hiding this comment.
i think we can use collections.singletonMap
preetkaran20
requested changes
Nov 21, 2023
|
|
||
| ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel1(queryParams); | ||
|
|
||
| verify(postRepository, times(1)).save(any()); |
There was a problem hiding this comment.
shall we also assert on the arguments passed to the postRepository?
| } | ||
|
|
||
| @Test | ||
| public void testGetVulnerablePayloadLevel6() { |
There was a problem hiding this comment.
I think adding a few tests would help here like input having NullByte and its impact on level 6 and level 5.
|
|
||
| ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel4(queryParams); | ||
|
|
||
| verify(postRepository, times(1)).save(any()); |
There was a problem hiding this comment.
I think we need to add a few more granular level of assertions then just verifying the call to postRepository.
|
Can you check ? Is it good like this ? |
preetkaran20
approved these changes
Nov 29, 2023
|
@SeheX Thanks a lot for the PR !!! |
This was referenced Dec 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.