Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing test for Persistent XSS in HTML #455

Merged
merged 4 commits into from
Nov 29, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
package org.sasanlabs.service.vulnerability.xss.reflected;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;

import org.sasanlabs.service.vulnerability.xss.persistent.PersistentXSSInHTMLTagVulnerability;
import org.sasanlabs.service.vulnerability.xss.persistent.PostRepository;
import org.springframework.http.ResponseEntity;

import java.util.HashMap;
import java.util.Map;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Mockito.*;


public class PersistentXSSInHTMLTagVulnerabilityTest {
@Mock
private PostRepository postRepository;

private PersistentXSSInHTMLTagVulnerability vulnerability;

@BeforeEach
public void setup() {
MockitoAnnotations.initMocks(this);
vulnerability = new PersistentXSSInHTMLTagVulnerability(postRepository);
}

@Test
public void testGetVulnerablePayloadLevel1() {
Map<String, String> queryParams = new HashMap<>();
queryParams.put("comment", "<script>alert('XSS')</script>");

ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel1(queryParams);

verify(postRepository, times(1)).save(any());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we also assert on the arguments passed to the postRepository?


assertEquals(200, response.getStatusCodeValue());
}

@Test
public void testGetVulnerablePayloadLevel1WithXSSInAttributeValue() {
Map<String, String> queryParams = new HashMap<>();
queryParams.put("comment", "<a href='javascript:alert(1)'>Click me</a>");

ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel1(queryParams);

verify(postRepository, times(1)).save(any());

assertEquals(200, response.getStatusCodeValue());
}

@Test
public void testGetVulnerablePayloadLevel2() {
Map<String, String> queryParams = new HashMap<>();
queryParams.put("comment", "<img src='x' onerror='alert(1)'>");

ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel2(queryParams);

verify(postRepository, times(1)).save(any());

assertEquals(200, response.getStatusCodeValue());
}

@Test
public void testGetVulnerablePayloadLevel3() {
Map<String, String> queryParams = new HashMap<>();
queryParams.put("comment", "<script>alert('XSS')</script>");

ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel3(queryParams);

verify(postRepository, times(1)).save(any());

assertEquals(200, response.getStatusCodeValue());
}

@Test
public void testGetVulnerablePayloadLevel4() {
Map<String, String> queryParams = new HashMap<>();
queryParams.put("comment", "<img src='x' onerror='alert(1)'>");

ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel4(queryParams);

verify(postRepository, times(1)).save(any());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add a few more granular level of assertions then just verifying the call to postRepository.


assertEquals(200, response.getStatusCodeValue());
}

@Test
public void testGetVulnerablePayloadLevel5() {
Map<String, String> queryParams = new HashMap<>();
queryParams.put("comment", "<script>alert('XSS')</script>");

ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel5(queryParams);

verify(postRepository, times(1)).save(any());

assertEquals(200, response.getStatusCodeValue());
}

@Test
public void testGetVulnerablePayloadLevel6() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a few tests would help here like input having NullByte and its impact on level 6 and level 5.

Map<String, String> queryParams = new HashMap<>();
queryParams.put("comment", "<img src='x' onerror='alert(1)'>");

ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel6(queryParams);

verify(postRepository, times(1)).save(any());

assertEquals(200, response.getStatusCodeValue());
}

@Test
public void testGetVulnerablePayloadLevel7() {
Map<String, String> queryParams = new HashMap<>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can use collections.singletonMap

queryParams.put("comment", "<script>alert('XSS')</script>");

ResponseEntity<String> response = vulnerability.getVulnerablePayloadLevel7(queryParams);

verify(postRepository, times(1)).save(any());

assertEquals(200, response.getStatusCodeValue());
}
}
Loading