Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORY-443] Add flag --no-letsencrypt when creating a domain #1058

Merged
merged 9 commits into from
Apr 26, 2024
Merged

[STORY-443] Add flag --no-letsencrypt when creating a domain #1058

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5af36f3
Bump to go-scalingo/v7
leo-scalingo Apr 19, 2024
61fe657
[STORY-443] Add flag --no-letsencrypt when creating a domain
leo-scalingo Apr 19, 2024
8eba5f7
Add Changelog
leo-scalingo Apr 19, 2024
f848883
feat: update output of 'domains' in order to take letsencrypt_enabled…
leo-scalingo Apr 19, 2024
52e9462
Fix error management
leo-scalingo Apr 19, 2024
a682426
style(import): remove useless scalingo alias for go-scalingo
curzolapierre Apr 25, 2024
f2478a3
Update CHANGELOG.md
leo-scalingo Apr 26, 2024
115a326
Update domains/list.go
leo-scalingo Apr 26, 2024
c25b0be
go tidy
leo-scalingo Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -2,7 +2,8 @@

### To be Released

* fix(cmd): addons-info working for non-db addons ([PR#1055](https://github.com/Scalingo/cli/pull/1055))
* feat(domains): `domains-add` now supports `--no-letsencrypt` flag to completely disable Let's Encrypt certificat generation
* fix(cmd): `addons-info` working for non-db addons ([PR#1055](https://github.com/Scalingo/cli/pull/1055))

### 1.31.0

2 changes: 1 addition & 1 deletion addons/config.go
View file
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

2 changes: 1 addition & 1 deletion addons/destroy.go
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Destroy(ctx context.Context, app, addonID string) error {
2 changes: 1 addition & 1 deletion addons/info.go
View file
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ import (
"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/db"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

// Info is the command handler displaying static information about one given addon
2 changes: 1 addition & 1 deletion addons/provision.go
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ import (
"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Provision(ctx context.Context, app, addon, plan string) error {
2 changes: 1 addition & 1 deletion addons/upgrade.go
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Upgrade(ctx context.Context, app, addonID, plan string) error {
2 changes: 1 addition & 1 deletion alerts/add.go
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

2 changes: 1 addition & 1 deletion alerts/update.go
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

2 changes: 1 addition & 1 deletion apps/create.go
View file
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Create(ctx context.Context, appName string, remote string, buildpack string) error {
2 changes: 1 addition & 1 deletion apps/events.go
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/events"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Events(ctx context.Context, app string, paginationOpts scalingo.PaginationOpts) error {
4 changes: 2 additions & 2 deletions apps/info.go
View file
Original file line number Diff line number Diff line change
@@ -8,8 +8,8 @@ import (
"github.com/olekukonko/tablewriter"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
"github.com/Scalingo/go-utils/errors/v2"
)

4 changes: 2 additions & 2 deletions apps/logs.go
View file
Original file line number Diff line number Diff line change
@@ -11,8 +11,8 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/logs"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

type WSEvent struct {
2 changes: 1 addition & 1 deletion apps/one_off_stop.go
View file
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func OneOffStop(ctx context.Context, appName, oneOffLabel string) error {
2 changes: 1 addition & 1 deletion apps/operations.go
View file
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
scalingo "github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
errors "github.com/Scalingo/go-utils/errors/v2"
)

2 changes: 1 addition & 1 deletion apps/restart.go
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Restart(ctx context.Context, app string, sync bool, args []string) error {
4 changes: 2 additions & 2 deletions apps/run.go
View file
Original file line number Diff line number Diff line change
@@ -28,8 +28,8 @@ import (
"github.com/Scalingo/cli/io"
"github.com/Scalingo/cli/signals"
"github.com/Scalingo/cli/term"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
errors "github.com/Scalingo/go-utils/errors/v2"
)

4 changes: 2 additions & 2 deletions apps/run/run_unix.go
View file
Original file line number Diff line number Diff line change
@@ -18,8 +18,8 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/httpclient"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

type UpdateTtyParams struct {
2 changes: 1 addition & 1 deletion apps/run/run_windows.go
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ import (
"net"
"os"

scalingo "github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func NotifiedSignals() chan os.Signal {
6 changes: 3 additions & 3 deletions apps/scale.go
View file
Original file line number Diff line number Diff line change
@@ -13,9 +13,9 @@ import (
"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v6/http"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
"github.com/Scalingo/go-scalingo/v7/http"
"github.com/Scalingo/go-utils/errors/v2"
)

2 changes: 1 addition & 1 deletion apps/sendsignal.go
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

2 changes: 1 addition & 1 deletion apps/stats.go
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

const (
2 changes: 1 addition & 1 deletion autoscalers/add.go
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Add(ctx context.Context, app string, params scalingo.AutoscalerAddParams) error {
2 changes: 1 addition & 1 deletion autoscalers/get_from_container_type.go
View file
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ import (

"gopkg.in/errgo.v1"

"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

var (
2 changes: 1 addition & 1 deletion autoscalers/update.go
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

2 changes: 1 addition & 1 deletion cmd/alerts.go
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import (
"github.com/Scalingo/cli/cmd/autocomplete"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
scalingo "github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

var (
4 changes: 2 additions & 2 deletions cmd/autocomplete/apps.go
View file
Original file line number Diff line number Diff line change
@@ -10,8 +10,8 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

type appsCache struct {
4 changes: 2 additions & 2 deletions cmd/autocomplete/collaborators_add.go
View file
Original file line number Diff line number Diff line change
@@ -8,8 +8,8 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

func CollaboratorsAddAutoComplete(c *cli.Context) error {
2 changes: 1 addition & 1 deletion cmd/autocomplete/current_app.go
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7/debug"
)

func CurrentAppCompletion(c *cli.Context) string {
2 changes: 1 addition & 1 deletion cmd/autocomplete/flag_app.go
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ import (

"github.com/urfave/cli/v2"

"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7/debug"
)

func FlagAppAutoComplete(c *cli.Context) bool {
2 changes: 1 addition & 1 deletion cmd/autoscalers.go
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import (
"github.com/Scalingo/cli/cmd/autocomplete"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

var (
4 changes: 2 additions & 2 deletions cmd/commands.go
View file
Original file line number Diff line number Diff line change
@@ -12,8 +12,8 @@ import (
"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/session"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

type AppCommands struct {
2 changes: 1 addition & 1 deletion cmd/databases.go
View file
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ import (
dbUsers "github.com/Scalingo/cli/db/users"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

var (
4 changes: 2 additions & 2 deletions cmd/deployments.go
View file
Original file line number Diff line number Diff line change
@@ -10,8 +10,8 @@ import (
"github.com/Scalingo/cli/deployments"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
scalingo "github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/io"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/io"
)

var (
Loading