Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity embedding (android 12L) #179

Open
wants to merge 1 commit into
base: sc
Choose a base branch
from

Conversation

Sinofine
Copy link

@Sinofine Sinofine commented Feb 25, 2023

pj.mp4

mobile view (it doesnot affect small screens)

ww.mp4

@Sinofine Sinofine changed the title activity embedding activity embedding (android 12L) Feb 25, 2023
@SpiritCroc
Copy link
Member

SpiritCroc commented Mar 4, 2023

Thank you! On first glance looks great on emulator (my real tablet is still only A11...) 👍

Note to self: code resembles what's described here, so seems good: https://developer.android.com/guide/topics/large-screens/activity-embedding

Android Studio tells me there is a more recent -alpha06 for androirdx.window, though it doesn't compile as is when bumping the version, maybe some API changed? 🤔

Would it be hard to hide behind a feature flag? Testing on foldable emulator, I got duplicate "please verify" banners, and the navigation drawer is larger than the left activity, thus being cut when expanded. Both not too bad if we can make this a labs setting - otherwise dunno, maybe worth having a while in beta to detect and fix anything before getting it into a stable release.

@SpiritCroc
Copy link
Member

Oh, just wanted to test logging in, but noticed I can't even log out with this one, dialog is cut as well :/

Screenshot_2023-03-04_15-39-55

@Sinofine
Copy link
Author

Sinofine commented Mar 4, 2023

maybe it's better to add width of the left panel. The alpha06 version introduced several interface changes to the activity embedding.

when the device is wide enough, the logout dialog is okay.
Screenshot_20230304_235618_SchildiChat dbg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants