SLVUU-90: Add constraints to name, group, and user in BaseMetadata #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfisher-scottlogic
requested review from
pling-scottlogic and
vferraro-scottlogic
cfisher-scottlogic
force-pushed
the
SLVUU-90-metadata-fields-required
branch
from
1f027bf to
11eb0b6
Compare
cfisher-scottlogic
changed the title
pling-scottlogic
approved these changes
Nov 21, 2023
|
Opened a PR on the finos fork (finos#991). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #90, we want the server to enforce a constraint that all layout metadata fields are required (except screenshot).
This PR makes all fields except
screenshotrequired inBaseMetadata. This applies the constraint to both the controller level request DTO, and the database entity. Tests have been added for the controller level constraint, as this is the behaviour we're concerned with.