feat(chart): exposed retry constants as helm chart #5889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look ok to me at a first pass. Could you confirm whether you've already tested this PR by spinning up a Core 2 cluster (kind or klaw), with one of the values from the helm-chart updated and verifying that the agent was started with updated parameters? |
|
Hello @lc525 i'm able to test helm and its working fine.
|
lc525
added a commit
to lc525/seldon-core
that referenced
this pull request
Oct 2, 2024
In SeldonIO#5889, we've missed updating the agent for triton in the published components.yaml Running `make create` in `[seldon-core]/k8s/` has surfaced the diff.
lc525
added a commit
that referenced
this pull request
Oct 2, 2024
In #5889, we've missed updating the agent for triton in the published components.yaml Running `make create` in `[seldon-core]/k8s/` has surfaced the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a follow up PR of #5875
These parameters (defaults) are currently hardcoded here.
These parameters could be exposed as env variables and also allow the user to get them configured via helm.
Which issue(s) this PR fixes:
Fixes # INFRA-1115