Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): exposed retry constants as helm chart #5889

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat(chart): exposed retry constants as helm chart #5889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions k8s/helm-charts/seldon-core-v2-setup/templates/seldon-v2-components.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1539,6 +1539,22 @@ spec:
value: '{{ .Values.serverConfig.agent.modelInactiveSecondsThreshold }}'
- name: SELDON_SCALING_STATS_PERIOD_SECONDS
value: '{{ .Values.serverConfig.agent.scalingStatsPeriodSeconds }}'
- name: SELDON_MAX_TIME_READY_SUB_SERVICE_AFTER_START_SECONDS
value: '{{ .Values.serverConfig.agent.maxElapsedTimeReadySubServiceAfterStartSeconds
}}'
- name: SELDON_MAX_ELAPSED_TIME_READY_SUB_SERVICE_BEFORE_START_MINUTES
value: '{{ .Values.serverConfig.agent.maxElapsedTimeReadySubServiceBeforeStartMinutes
}}'
- name: SELDON_PERIOD_READY_SUB_SERVICE_SECONDS
value: '{{ .Values.serverConfig.agent.periodReadySubServiceSeconds }}'
- name: SELDON_MAX_LOAD_ELAPSED_TIME_MINUTES
value: '{{ .Values.serverConfig.agent.maxLoadElapsedTimeMinutes }}'
- name: SELDON_MAX_UNLOAD_ELAPSED_TIME_MINUTES
value: '{{ .Values.serverConfig.agent.maxUnloadElapsedTimeMinutes }}'
- name: SELDON_MAX_LOAD_RETRY_COUNT
value: '{{ .Values.serverConfig.agent.maxLoadRetryCount }}'
- name: SELDON_MAX_UNLOAD_RETRY_COUNT
value: '{{ .Values.serverConfig.agent.maxUnloadRetryCount }}'
- name: SELDON_OVERCOMMIT_PERCENTAGE
value: '{{ .Values.serverConfig.agent.overcommitPercentage }}'
- name: CONTROL_PLANE_SECURITY_PROTOCOL
Expand Down Expand Up @@ -1787,6 +1803,22 @@ spec:
value: '{{ .Values.serverConfig.agent.modelInactiveSecondsThreshold }}'
- name: SELDON_SCALING_STATS_PERIOD_SECONDS
value: '{{ .Values.serverConfig.agent.scalingStatsPeriodSeconds }}'
- name: SELDON_MAX_TIME_READY_SUB_SERVICE_AFTER_START_SECONDS
value: '{{ .Values.serverConfig.agent.maxElapsedTimeReadySubServiceAfterStartSeconds
}}'
- name: SELDON_MAX_ELAPSED_TIME_READY_SUB_SERVICE_BEFORE_START_MINUTES
value: '{{ .Values.serverConfig.agent.maxElapsedTimeReadySubServiceBeforeStartMinutes
}}'
- name: SELDON_PERIOD_READY_SUB_SERVICE_SECONDS
value: '{{ .Values.serverConfig.agent.periodReadySubServiceSeconds }}'
- name: SELDON_MAX_LOAD_ELAPSED_TIME_MINUTES
value: '{{ .Values.serverConfig.agent.maxLoadElapsedTimeMinutes }}'
- name: SELDON_MAX_UNLOAD_ELAPSED_TIME_MINUTES
value: '{{ .Values.serverConfig.agent.maxUnloadElapsedTimeMinutes }}'
- name: SELDON_MAX_LOAD_RETRY_COUNT
value: '{{ .Values.serverConfig.agent.maxLoadRetryCount }}'
- name: SELDON_MAX_UNLOAD_RETRY_COUNT
value: '{{ .Values.serverConfig.agent.maxUnloadRetryCount }}'
- name: SELDON_OVERCOMMIT_PERCENTAGE
value: '{{ .Values.serverConfig.agent.overcommitPercentage }}'
- name: CONTROL_PLANE_SECURITY_PROTOCOL
Expand Down
7 changes: 7 additions & 0 deletions k8s/helm-charts/seldon-core-v2-setup/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,13 @@ serverConfig:
scalingStatsPeriodSeconds: "20"
modelInferenceLagThreshold: "30"
modelInactiveSecondsThreshold: "600"
maxElapsedTimeReadySubServiceAfterStartSeconds: "30"
maxElapsedTimeReadySubServiceBeforeStartMinutes: "15"
periodReadySubServiceSeconds: "60"
maxLoadElapsedTimeMinutes: "120"
maxUnloadElapsedTimeMinutes: "15"
maxLoadRetryCount: "5"
maxUnloadRetryCount: "1"
resources:
cpu: 200m
memory: 1Gi
Expand Down
7 changes: 7 additions & 0 deletions k8s/helm-charts/seldon-core-v2-setup/values.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,13 @@ serverConfig:
scalingStatsPeriodSeconds: "20"
modelInferenceLagThreshold: "30"
modelInactiveSecondsThreshold: "600"
maxElapsedTimeReadySubServiceAfterStartSeconds: "30"
maxElapsedTimeReadySubServiceBeforeStartMinutes: "15"
periodReadySubServiceSeconds: "60"
maxLoadElapsedTimeMinutes: "120"
maxUnloadElapsedTimeMinutes: "15"
maxLoadRetryCount: "5"
maxUnloadRetryCount: "1"
resources:
cpu: 200m
memory: 1Gi
Expand Down
14 changes: 14 additions & 0 deletions k8s/kustomize/helm-components-sc/patch_mlserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,20 @@ spec:
value: '{{ .Values.serverConfig.agent.modelInactiveSecondsThreshold }}'
- name: SELDON_SCALING_STATS_PERIOD_SECONDS
value: '{{ .Values.serverConfig.agent.scalingStatsPeriodSeconds }}'
- name: SELDON_MAX_TIME_READY_SUB_SERVICE_AFTER_START_SECONDS
value: '{{ .Values.serverConfig.agent.maxElapsedTimeReadySubServiceAfterStartSeconds }}'
- name: SELDON_MAX_ELAPSED_TIME_READY_SUB_SERVICE_BEFORE_START_MINUTES
value: '{{ .Values.serverConfig.agent.maxElapsedTimeReadySubServiceBeforeStartMinutes }}'
- name: SELDON_PERIOD_READY_SUB_SERVICE_SECONDS
value: '{{ .Values.serverConfig.agent.periodReadySubServiceSeconds }}'
- name: SELDON_MAX_LOAD_ELAPSED_TIME_MINUTES
value: '{{ .Values.serverConfig.agent.maxLoadElapsedTimeMinutes }}'
- name: SELDON_MAX_UNLOAD_ELAPSED_TIME_MINUTES
value: '{{ .Values.serverConfig.agent.maxUnloadElapsedTimeMinutes }}'
- name: SELDON_MAX_LOAD_RETRY_COUNT
value: '{{ .Values.serverConfig.agent.maxLoadRetryCount }}'
- name: SELDON_MAX_UNLOAD_RETRY_COUNT
value: '{{ .Values.serverConfig.agent.maxUnloadRetryCount }}'
- name: SELDON_OVERCOMMIT_PERCENTAGE
value: '{{ .Values.serverConfig.agent.overcommitPercentage }}'
- name: CONTROL_PLANE_SECURITY_PROTOCOL
Expand Down
14 changes: 14 additions & 0 deletions k8s/kustomize/helm-components-sc/patch_triton.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,20 @@ spec:
value: '{{ .Values.serverConfig.agent.modelInactiveSecondsThreshold }}'
- name: SELDON_SCALING_STATS_PERIOD_SECONDS
value: '{{ .Values.serverConfig.agent.scalingStatsPeriodSeconds }}'
- name: SELDON_MAX_TIME_READY_SUB_SERVICE_AFTER_START_SECONDS
value: '{{ .Values.serverConfig.agent.maxElapsedTimeReadySubServiceAfterStartSeconds }}'
- name: SELDON_MAX_ELAPSED_TIME_READY_SUB_SERVICE_BEFORE_START_MINUTES
value: '{{ .Values.serverConfig.agent.maxElapsedTimeReadySubServiceBeforeStartMinutes }}'
- name: SELDON_PERIOD_READY_SUB_SERVICE_SECONDS
value: '{{ .Values.serverConfig.agent.periodReadySubServiceSeconds }}'
- name: SELDON_MAX_LOAD_ELAPSED_TIME_MINUTES
value: '{{ .Values.serverConfig.agent.maxLoadElapsedTimeMinutes }}'
- name: SELDON_MAX_UNLOAD_ELAPSED_TIME_MINUTES
value: '{{ .Values.serverConfig.agent.maxUnloadElapsedTimeMinutes }}'
- name: SELDON_MAX_LOAD_RETRY_COUNT
value: '{{ .Values.serverConfig.agent.maxLoadRetryCount }}'
- name: SELDON_MAX_UNLOAD_RETRY_COUNT
value: '{{ .Values.serverConfig.agent.maxUnloadRetryCount }}'
- name: SELDON_OVERCOMMIT_PERCENTAGE
value: '{{ .Values.serverConfig.agent.overcommitPercentage }}'
- name: CONTROL_PLANE_SECURITY_PROTOCOL
Expand Down
14 changes: 14 additions & 0 deletions k8s/yaml/components.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,6 +1157,20 @@ spec:
value: '20'
- name: SELDON_OVERCOMMIT_PERCENTAGE
value: '10'
- name: SELDON_MAX_TIME_READY_SUB_SERVICE_AFTER_START_SECONDS
value: '30'
- name: SELDON_MAX_ELAPSED_TIME_READY_SUB_SERVICE_BEFORE_START_MINUTES
value: '15'
- name: SELDON_PERIOD_READY_SUB_SERVICE_SECONDS
value: '60'
- name: SELDON_MAX_LOAD_ELAPSED_TIME_MINUTES
value: '120'
- name: SELDON_MAX_UNLOAD_ELAPSED_TIME_MINUTES
value: '15'
- name: SELDON_MAX_LOAD_RETRY_COUNT
value: '5'
- name: SELDON_MAX_UNLOAD_RETRY_COUNT
value: '1'
- name: CONTROL_PLANE_SECURITY_PROTOCOL
value: 'PLAINTEXT'
- name: CONTROL_PLANE_CLIENT_TLS_SECRET_NAME
Expand Down
Loading