Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix - failing CI test #104

Merged
merged 16 commits into from
Feb 26, 2024
Merged

Conversation

marko220991
Copy link
Contributor

After taking a closer look at failing CI test, some changes were made and now all tests are working fine.
Some builtin PHPUnit functions, like assertContains and assertInternalType, were depracated, and that is why we had warnings and failures.

After we updated those php files with new functions, all seems to work fine now.

  • Instead of assertContains we used assertStringContainsStringIgnoringCase();
  • Instead of assertInternalType we used assertIsArray();

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (226144c) to head (df49ac5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage     72.72%   72.72%           
  Complexity       24       24           
=========================================
  Files             5        5           
  Lines            88       88           
=========================================
  Hits             64       64           
  Misses           24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gesinn-it-gea gesinn-it-gea merged commit 7d7b98f into SemanticMediaWiki:master Feb 26, 2024
4 checks passed
@gesinn-it-gea gesinn-it-gea mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants