Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix - failing CI test #104

Merged
merged 16 commits into from
Feb 26, 2024
Merged

Bug fix - failing CI test #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2e0c662
Update tests
marko220991 Feb 24, 2024
2b9bef9
Check and update assertions in tests
marko220991 Feb 24, 2024
dc71823
Increase mediawiki version in ci
marko220991 Feb 24, 2024
02ac9d2
Return to old version od mediawiki
marko220991 Feb 24, 2024
cebd79d
Test change mediawiki version
marko220991 Feb 24, 2024
fb7a65d
Change smw_version check test
marko220991 Feb 24, 2024
3fa3cbe
Increase mediawiki version to 1.40
marko220991 Feb 24, 2024
d7fb752
Increase mediawiki to latest 1.42
marko220991 Feb 24, 2024
79343f4
Change and modify test strategy
marko220991 Feb 24, 2024
03144f3
Change assertion check within tests
marko220991 Feb 24, 2024
844a0b3
Add assertIsArray instead of assertInternalType
marko220991 Feb 24, 2024
4860bb9
Update assertion integration tests
marko220991 Feb 24, 2024
7c9949b
Add assertIsArray function
marko220991 Feb 24, 2024
101f658
Update integration test
marko220991 Feb 24, 2024
96d2a84
Add mediawiki latest version check
marko220991 Feb 25, 2024
df49ac5
Update mediawiki version
marko220991 Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ jobs:
database_type: mysql
database_image: "mariadb:latest"
coverage: false
experimental: true
experimental: false
- mediawiki_version: '1.40'
smw_version: dev-master
smw_version: 'dev-master'
php_version: 8.1
database_type: mysql
database_image: "mariadb:latest"
Expand Down
3 changes: 1 addition & 2 deletions tests/phpunit/Integration/I18nJsonFileIntegrityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ public function testI18NJsonDecodeEncode( $file ) {

$contents = file_get_contents( $file );

$this->assertInternalType(
'array',
$this->assertIsArray(
json_decode( $contents, true ),
'Failed with ' . $this->getDescriptiveJsonError( json_last_error() ) . ' in ' . $file
);
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/Unit/MermaidParserFunctionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public function testParse($text, $expected)
$mockExtractor
);

$this->assertContains(
$this->assertStringContainsStringIgnoringCase(
$expected,
$instance->parse($text)
);
Expand Down
Loading