[VP] Add categories for vehicle cooling systems #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+2367
to
+2379
| - vp-1-4-22-1 | ||
| - vp-1-4-22-2 | ||
| - vp-1-4-22-3 | ||
| - vp-1-4-22-4 | ||
| - vp-1-4-22-5 | ||
| - vp-1-4-22-6 | ||
| - vp-1-4-22-7 | ||
| - vp-1-4-22-8 | ||
| - vp-1-4-22-9 | ||
| - vp-1-4-22-10 | ||
| - vp-1-4-22-11 | ||
| - vp-1-4-22-12 | ||
| - vp-1-4-22-13 |
There was a problem hiding this comment.
There appears to be a mismatch between the children list and category definitions. The vp-1-4-22-13 (Hoses) category is referenced in the children array but lacks a corresponding category definition in the taxonomy. To resolve this inconsistency, either add the complete category definition for vp-1-4-22-13 or remove it from the children list.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Looks like dist might need be ran again.
ornanatan
changed the title
ornanatan
requested review from
alokaraju,
tylerrowsell and
ricardotejedorsanz
ornanatan
added
2025-01
taxonomy-tree-requests
Comment on lines
+2367
to
+2379
| - vp-1-4-22-1 | ||
| - vp-1-4-22-2 | ||
| - vp-1-4-22-3 | ||
| - vp-1-4-22-4 | ||
| - vp-1-4-22-5 | ||
| - vp-1-4-22-6 | ||
| - vp-1-4-22-7 | ||
| - vp-1-4-22-8 | ||
| - vp-1-4-22-9 | ||
| - vp-1-4-22-10 | ||
| - vp-1-4-22-11 | ||
| - vp-1-4-22-12 | ||
| - vp-1-4-22-13 |
There was a problem hiding this comment.
Looks like dist might need be ran again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Vehicle Cooling Systems category and its subcategories. Please note that the attributes Pressure Rating, Temperature Rating, Diameter, Capacity, and Flow Rate will be published as part of the Unit of Measurement task