Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VP] Add categories for vehicle cooling systems #447

Merged
merged 4 commits into from
Dec 10, 2024
Merged

[VP] Add categories for vehicle cooling systems #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5c8ca6
add categories for vehicle cooling systems
ornanatan Nov 18, 2024
673cf3f
rerun due to dist issue
ornanatan Nov 19, 2024
e2c38fa
add motor vehicle cooling system category- mapping
ornanatan Dec 3, 2024
a33ac53
add-motor-vehicle-cooling-systems-category
ornanatan Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 127 additions & 0 deletions data/categories/vp_vehicles_parts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,7 @@
- vp-1-4-19
- vp-1-4-20
- vp-1-4-21
- vp-1-4-22
attributes:
- color
- item_condition
Expand Down Expand Up @@ -2809,6 +2810,132 @@
- item_material
- manufacturer_type
- pattern
- id: vp-1-4-22
name: Motor Vehicle Cooling Systems
children:
- vp-1-4-22-1
- vp-1-4-22-2
- vp-1-4-22-3
- vp-1-4-22-4
- vp-1-4-22-5
- vp-1-4-22-6
- vp-1-4-22-7
- vp-1-4-22-8
- vp-1-4-22-9
- vp-1-4-22-10
- vp-1-4-22-11
- vp-1-4-22-12
- vp-1-4-22-13
Comment on lines +2816 to +2828
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a mismatch between the children list and category definitions. The vp-1-4-22-13 (Hoses) category is referenced in the children array but lacks a corresponding category definition in the taxonomy. To resolve this inconsistency, either add the complete category definition for vp-1-4-22-13 or remove it from the children list.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like dist might need be ran again.

attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-1
name: Radiator Caps
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-2
name: Fan Shrouds
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-3
name: Thermostats
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-4
name: Radiator Panels
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-5
name: Hose Fittings
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-6
name: Radiator Overflow Tanks
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-7
name: Water Necks
children: []
attributes:
- angles_supported
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-8
name: Expansion Tanks
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-9
name: Expansion Tank Caps
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-10
name: Radiators
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-11
name: Radiator Fans
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-12
name: Water Pumps
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-4-22-13
name: Radiator Hoses
children: []
attributes:
- item_condition
- item_material
- manufacturer_type
- motor_vehicle_type
- id: vp-1-5
name: Vehicle Maintenance, Care & Decor
children:
Expand Down
70 changes: 70 additions & 0 deletions data/integrations/google/2021-09-21/mappings/from_shopify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50852,6 +50852,76 @@ rules:
output:
product_category_id:
- '2534'
- input:
product_category_id: vp-1-4-22
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-1
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-2
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-3
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-4
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-5
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-6
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-7
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-8
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-9
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-10
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-11
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-12
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-4-22-13
output:
product_category_id:
- '899'
- input:
product_category_id: vp-1-5
output:
Expand Down
42 changes: 42 additions & 0 deletions data/localizations/categories/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30689,6 +30689,48 @@ en:
vp-1-4-21-4-4:
name: Wiper Motors
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Window Parts & Accessories > Windshield Wiper Systems & Components > Wiper Motors
vp-1-4-22:
name: Motor Vehicle Cooling Systems
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems
vp-1-4-22-1:
name: Radiator Caps
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Radiator Caps
vp-1-4-22-2:
name: Fan Shrouds
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Fan Shrouds
vp-1-4-22-3:
name: Thermostats
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Thermostats
vp-1-4-22-4:
name: Radiator Panels
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Radiator Panels
vp-1-4-22-5:
name: Hose Fittings
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Hose Fittings
vp-1-4-22-6:
name: Radiator Overflow Tanks
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Radiator Overflow Tanks
vp-1-4-22-7:
name: Water Necks
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Water Necks
vp-1-4-22-8:
name: Expansion Tanks
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Expansion Tanks
vp-1-4-22-9:
name: Expansion Tank Caps
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Expansion Tank Caps
vp-1-4-22-10:
name: Radiators
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Radiators
vp-1-4-22-11:
name: Radiator Fans
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Radiator Fans
vp-1-4-22-12:
name: Water Pumps
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Water Pumps
vp-1-4-22-13:
name: Radiator Hoses
context: Vehicles & Parts > Vehicle Parts & Accessories > Motor Vehicle Parts > Motor Vehicle Cooling Systems > Radiator Hoses
vp-1-5:
name: Vehicle Maintenance, Care & Decor
context: Vehicles & Parts > Vehicle Parts & Accessories > Vehicle Maintenance, Care & Decor
Expand Down
Loading
Loading