-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SG] Expand E-Scooters categories #470
base: main
Are you sure you want to change the base?
Conversation
@@ -21023,6 +21023,15 @@ en: | |||
egg_turning__semi_automatic: | |||
name: Semi-automatic | |||
context: Egg turning | |||
electric_scooter_motors_type__brushed_dc_motor: | |||
name: brushed DC Motor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing capitalization here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fixed
name: brushed DC Motor | ||
context: Electric scooter motors type | ||
electric_scooter_motors_type__brushless_dc_motor: | ||
name: Brushless dc motor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dc motor
Should these be capitalized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the DC should be capitalized..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it to Brushed DC motor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the new e-scooter type categories. Attributes need some tweaks.
Let's discuss together the parts & accessories categories for consistency with other areas and to minimise overlaps.
name: Electric scooter motors type | ||
description: Specifies the type and configuration of scooter motors, such as brushed DC or brushless dc | ||
friendly_id: electric_scooter_motors_type | ||
handle: electric-scooter-motors-type | ||
values: | ||
- electric_scooter_motors_type__brushed_dc_motor | ||
- electric_scooter_motors_type__brushless_dc_motor | ||
- electric_scooter_motors_type__other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the importance of this one as a standard attribute, I can't find enough examples?
values: | ||
- scooter_brake_type__combination_brakes | ||
- scooter_brake_type__disc_brakes | ||
- scooter_brake_type__drum_brakes | ||
- scooter_brake_type__foot_brakes | ||
- scooter_brake_type__regenerative_brakes | ||
- scooter_brake_type__other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we should remove the word "brakes" from these values to keep things consistent (see Bicycle brake type
as an example).
name: Commuter E-Scooters | ||
children: [] | ||
attributes: | ||
- age_group | ||
- color |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are creating a separate category for Youth E-Scooters
; I wouldn't add the attribute age group
for things like Commuter E-Scooters.
name: Off-Road E-Scooters | ||
children: [] | ||
attributes: | ||
- age_group | ||
- color | ||
- pattern | ||
- features | ||
- range_type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: Electrical Components | ||
children: [] | ||
attributes: | ||
- material | ||
- id: sg-4-15-3-7 | ||
name: Electric Motors | ||
children: [] | ||
attributes: | ||
- electric_scooter_motors_type | ||
- material |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These create many overlaps with categories in Hardware and Electronics, let's review them together next week.
electric_scooter_motors_type: | ||
name: Electric scooter motors type | ||
description: Specifies the type and configuration of scooter motors, such as brushed DC or brushless dc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "motor type", without that "s".
Expand the E-Scooters category with new subcategories:
Commuter E-Scooters
Performance E-Scooters
Off-Road E-Scooters
Youth E-Scooters
A 'Features' attribute has been added for options such as foldable and lightweight, and a 'Range Type' attribute has also been included.