Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SG] Expand E-Scooters categories #470

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ornanatan
Copy link
Contributor

Expand the E-Scooters category with new subcategories:
Commuter E-Scooters
Performance E-Scooters
Off-Road E-Scooters
Youth E-Scooters
A 'Features' attribute has been added for options such as foldable and lightweight, and a 'Range Type' attribute has also been included.

@ornanatan ornanatan added taxonomy-tree-requests Suggestion to improve to the taxonomy tree 2025-01 labels Nov 27, 2024
@ornanatan ornanatan self-assigned this Nov 27, 2024
@@ -21023,6 +21023,15 @@ en:
egg_turning__semi_automatic:
name: Semi-automatic
context: Egg turning
electric_scooter_motors_type__brushed_dc_motor:
name: brushed DC Motor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing capitalization here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed

name: brushed DC Motor
context: Electric scooter motors type
electric_scooter_motors_type__brushless_dc_motor:
name: Brushless dc motor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dc motor
Should these be capitalized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the DC should be capitalized..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it to Brushed DC motor

Copy link
Contributor

@ricardotejedorsanz ricardotejedorsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the new e-scooter type categories. Attributes need some tweaks.
Let's discuss together the parts & accessories categories for consistency with other areas and to minimise overlaps.

Comment on lines +32368 to +32375
name: Electric scooter motors type
description: Specifies the type and configuration of scooter motors, such as brushed DC or brushless dc
friendly_id: electric_scooter_motors_type
handle: electric-scooter-motors-type
values:
- electric_scooter_motors_type__brushed_dc_motor
- electric_scooter_motors_type__brushless_dc_motor
- electric_scooter_motors_type__other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the importance of this one as a standard attribute, I can't find enough examples?

Comment on lines +32360 to +32366
values:
- scooter_brake_type__combination_brakes
- scooter_brake_type__disc_brakes
- scooter_brake_type__drum_brakes
- scooter_brake_type__foot_brakes
- scooter_brake_type__regenerative_brakes
- scooter_brake_type__other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should remove the word "brakes" from these values to keep things consistent (see Bicycle brake type as an example).

Comment on lines +12402 to 12406
name: Commuter E-Scooters
children: []
attributes:
- age_group
- color
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are creating a separate category for Youth E-Scooters; I wouldn't add the attribute age group for things like Commuter E-Scooters.

Comment on lines +12412 to +12419
name: Off-Road E-Scooters
children: []
attributes:
- age_group
- color
- pattern
- features
- range_type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prioritise a measurement attribute for range:

image

Comment on lines +12495 to +12504
name: Electrical Components
children: []
attributes:
- material
- id: sg-4-15-3-7
name: Electric Motors
children: []
attributes:
- electric_scooter_motors_type
- material
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These create many overlaps with categories in Hardware and Electronics, let's review them together next week.

Comment on lines +2213 to +2215
electric_scooter_motors_type:
name: Electric scooter motors type
description: Specifies the type and configuration of scooter motors, such as brushed DC or brushless dc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "motor type", without that "s".

@ricardotejedorsanz ricardotejedorsanz changed the title [SG] Expand E -Scooters category [SG] Expand E-Scooters categories Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025-01 taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants