Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SG] Expand E-Scooters categories #470

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[SG] Expand E-Scooters categories #470

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8234ed4
expand e scooters category
ornanatan Nov 26, 2024
7347b91
Expand E-Scooter category
ornanatan Nov 27, 2024
2a65b07
adding 2 more attributes
ornanatan Nov 27, 2024
54d2ea1
minor fixes
ornanatan Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions data/attributes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2440,9 +2440,9 @@ base_attributes:
- archery_style__3d_archery
- archery_style__bowhunting
- archery_style__compound_target
- archery_style__olympic_recurve
- archery_style__recreational
- archery_style__traditional
- archery_style__olympic_recurve
- archery_style__other
- id: 1306
name: String material
Expand Down Expand Up @@ -13068,8 +13068,8 @@ base_attributes:
friendly_id: coffee_product_form
handle: coffee-product-form
values:
- coffee_product_form__whole_bean
- coffee_product_form__ground
- coffee_product_form__whole_bean
- coffee_product_form__other
- id: 1978
name: Food product form
Expand Down Expand Up @@ -32059,8 +32059,8 @@ base_attributes:
friendly_id: caffeine_content
handle: caffeine-content
values:
- caffeine_content__low_caffeine
- caffeine_content__decaf
- caffeine_content__low_caffeine
- caffeine_content__regular
- caffeine_content__other
- id: 3416
Expand All @@ -32069,13 +32069,13 @@ base_attributes:
friendly_id: grind_size
handle: grind-size
values:
- grind_size__extra_coarse
- grind_size__coarse
- grind_size__medium_coarse
- grind_size__extra_coarse
- grind_size__extra_fine
- grind_size__fine
- grind_size__medium
- grind_size__medium_coarse
- grind_size__medium_fine
- grind_size__fine
- grind_size__extra_fine
- grind_size__other
- id: 3418
name: Dance style
Expand All @@ -32089,10 +32089,10 @@ base_attributes:
- dance_style__flamenco
- dance_style__hip_hop
- dance_style__irish_dance
- dance_style__jazz
- dance_style__salsa
- dance_style__swing_dance
- dance_style__tap_dance
- dance_style__jazz
- dance_style__other
- id: 3425
name: Microphone design
Expand Down Expand Up @@ -32352,6 +32352,27 @@ base_attributes:
- broadhead_design__fixed_blade
- broadhead_design__mechanical
- broadhead_design__other
- id: 4678
name: Scooter brake type
description: Specifies the mechanism and design of scooter brakes, such as disc or drum
friendly_id: scooter_brake_type
handle: scooter-brake-type
values:
- scooter_brake_type__combination_brakes
- scooter_brake_type__disc_brakes
- scooter_brake_type__drum_brakes
- scooter_brake_type__foot_brakes
- scooter_brake_type__regenerative_brakes
- scooter_brake_type__other
Comment on lines +32360 to +32366
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should remove the word "brakes" from these values to keep things consistent (see Bicycle brake type as an example).

- id: 4679
name: Electric scooter motors type
description: Specifies the type and configuration of scooter motors, such as brushed DC or brushless dc
friendly_id: electric_scooter_motors_type
handle: electric-scooter-motors-type
values:
- electric_scooter_motors_type__brushed_dc_motor
- electric_scooter_motors_type__brushless_dc_motor
- electric_scooter_motors_type__other
Comment on lines +32368 to +32375
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the importance of this one as a standard attribute, I can't find enough examples?

extended_attributes:
- name: Shampoo/Conditioner effect
handle: shampoo-conditioner-effect
Expand Down
104 changes: 103 additions & 1 deletion data/categories/sg_sporting_goods.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10811,8 +10811,8 @@
- age_group
- archery_style
- color
- handwear_material
- hand_side
- handwear_material
- pattern
- target_gender
- id: sg-4-9-1-3
Expand Down Expand Up @@ -12382,24 +12382,126 @@
children:
- sg-4-15-1
- sg-4-15-2
- sg-4-15-3
attributes:
- age_group
- color
- pattern
- id: sg-4-15-1
name: E-Scooters
children:
- sg-4-15-1-1
- sg-4-15-1-2
- sg-4-15-1-3
- sg-4-15-1-4
attributes:
- age_group
- color
- pattern
- id: sg-4-15-1-1
name: Commuter E-Scooters
children: []
attributes:
- age_group
- color
Comment on lines +12402 to 12406
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are creating a separate category for Youth E-Scooters; I wouldn't add the attribute age group for things like Commuter E-Scooters.

- features
- pattern
- range_type
- wheel_type
- id: sg-4-15-1-2
name: Off-Road E-Scooters
children: []
attributes:
- age_group
- color
- pattern
- features
- range_type
Comment on lines +12412 to +12419
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prioritise a measurement attribute for range:

image

- wheel_type
- id: sg-4-15-1-3
name: Performance E-Scooters
children: []
attributes:
- age_group
- color
- features
- pattern
- range_type
- wheel_type
- id: sg-4-15-1-4
name: Youth E-Scooters
children: []
attributes:
- age_group
- color
- features
- pattern
- range_type
- wheel_type
- id: sg-4-15-2
name: Kick Scooters
children: []
attributes:
- age_group
- color
- features
- pattern
- range_type
- wheel_type
- id: sg-4-15-3
name: E-Scooters Parts
children:
- sg-4-15-3-1
- sg-4-15-3-2
- sg-4-15-3-3
- sg-4-15-3-4
- sg-4-15-3-5
- sg-4-15-3-6
- sg-4-15-3-7
attributes: []
- id: sg-4-15-3-1
name: Batteries & Chargers
children: []
attributes:
- battery_features
- ev_battery_type
- id: sg-4-15-3-2
name: Wheels & Tires
children: []
attributes:
- wheel_part_type
- wheel_type
- id: sg-4-15-3-3
name: Braking Systems
children: []
attributes:
- material
- scooter_brake_type
- id: sg-4-15-3-4
name: Handlebars & Controls
children: []
attributes:
- color
- material
- pattern
- id: sg-4-15-3-5
name: Frames & Body Parts
children: []
attributes:
- color
- material
- pattern
- id: sg-4-15-3-6
name: Electrical Components
children: []
attributes:
- material
- id: sg-4-15-3-7
name: Electric Motors
children: []
attributes:
- electric_scooter_motors_type
- material
Comment on lines +12495 to +12504
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These create many overlaps with categories in Hardware and Electronics, let's review them together next week.

- id: sg-4-16
name: Skateboarding
children:
Expand Down
6 changes: 6 additions & 0 deletions data/localizations/attributes/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2210,6 +2210,9 @@ en:
egg_turning:
name: Egg turning
description: Describes the method of rotating eggs in incubators, like automatic or manual
electric_scooter_motors_type:
name: Electric scooter motors type
description: Specifies the type and configuration of scooter motors, such as brushed DC or brushless dc
Comment on lines +2213 to +2215
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "motor type", without that "s".

electronic_drum_components:
name: Electronic drum components
description: Specifies the elements of an electronic drum set, such as drum module or drum pads
Expand Down Expand Up @@ -5171,6 +5174,9 @@ en:
scissor_blade_type:
name: Scissor blade type
description: Describes the shape and style of scissor blades, such as curved or scallop
scooter_brake_type:
name: Scooter brake type
description: Specifies the mechanism and design of scooter brakes, such as disc or drum
scope/sight_design:
name: Scope/Sight design
description: Describes the type of design for weapon scopes or sights, e.g. night vision, laser
Expand Down
36 changes: 36 additions & 0 deletions data/localizations/categories/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28625,9 +28625,45 @@ en:
sg-4-15-1:
name: E-Scooters
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters
sg-4-15-1-1:
name: Commuter E-Scooters
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters > Commuter E-Scooters
sg-4-15-1-2:
name: Off-Road E-Scooters
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters > Off-Road E-Scooters
sg-4-15-1-3:
name: Performance E-Scooters
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters > Performance E-Scooters
sg-4-15-1-4:
name: Youth E-Scooters
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters > Youth E-Scooters
sg-4-15-2:
name: Kick Scooters
context: Sporting Goods > Outdoor Recreation > Riding Scooters > Kick Scooters
sg-4-15-3:
name: E-Scooters Parts
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters Parts
sg-4-15-3-1:
name: Batteries & Chargers
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters Parts > Batteries & Chargers
sg-4-15-3-2:
name: Wheels & Tires
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters Parts > Wheels & Tires
sg-4-15-3-3:
name: Braking Systems
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters Parts > Braking Systems
sg-4-15-3-4:
name: Handlebars & Controls
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters Parts > Handlebars & Controls
sg-4-15-3-5:
name: Frames & Body Parts
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters Parts > Frames & Body Parts
sg-4-15-3-6:
name: Electrical Components
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters Parts > Electrical Components
sg-4-15-3-7:
name: Electric Motors
context: Sporting Goods > Outdoor Recreation > Riding Scooters > E-Scooters Parts > Electric Motors
sg-4-16:
name: Skateboarding
context: Sporting Goods > Outdoor Recreation > Skateboarding
Expand Down
27 changes: 27 additions & 0 deletions data/localizations/values/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21023,6 +21023,15 @@ en:
egg_turning__semi_automatic:
name: Semi-automatic
context: Egg turning
electric_scooter_motors_type__brushed_dc_motor:
name: brushed DC Motor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing capitalization here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed

context: Electric scooter motors type
electric_scooter_motors_type__brushless_dc_motor:
name: Brushless dc motor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dc motor
Should these be capitalized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the DC should be capitalized..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it to Brushed DC motor

context: Electric scooter motors type
electric_scooter_motors_type__other:
name: Other
context: Electric scooter motors type
electronic_drum_components__cymbal_pads:
name: Cymbal pads
context: Electronic drum components
Expand Down Expand Up @@ -47885,6 +47894,24 @@ en:
scissor_blade_type__straight:
name: Straight
context: Scissor blade type
scooter_brake_type__combination_brakes:
name: Combination brakes
context: Scooter brake type
scooter_brake_type__disc_brakes:
name: Disc brakes
context: Scooter brake type
scooter_brake_type__drum_brakes:
name: Drum brakes
context: Scooter brake type
scooter_brake_type__foot_brakes:
name: Foot brakes
context: Scooter brake type
scooter_brake_type__other:
name: Other
context: Scooter brake type
scooter_brake_type__regenerative_brakes:
name: Regenerative brakes
context: Scooter brake type
scope/sight_design__holographic:
name: Holographic
context: Scope/Sight design
Expand Down
Loading
Loading