Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make DJFuture results nonnull in objective C" #188

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

li-feng-sc
Copy link
Contributor

This reverts commit 1135f3a.

nonnull prevents future<optional>, this is because optional is translated to nullable pointers in objc

@li-feng-sc li-feng-sc requested a review from bholmes-sc August 30, 2024 10:31
@bholmes-sc bholmes-sc merged commit 4dafc5b into main Sep 3, 2024
1 check passed
@bholmes-sc bholmes-sc deleted the lf/revert-objc-future-nonnull branch September 3, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants