Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make DJFuture results nonnull in objective C" #188

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Revert "Make DJFuture results nonnull in objective C" #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions support-lib/objc/DJFuture.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
// If the future is ready, then calling its `get` method will not block.
- (BOOL) isReady;
// Block and wait for the result (or exception). This can only be called once.
- (nonnull DJValue) get;
- (nullable DJValue) get;
// Tell the future to Call the specified handler routine when it becomes
// ready. Returns a new future that wraps the return value of the handler
// routine. The current future becomes invalid after this call.
Expand All @@ -40,7 +40,7 @@
- (nonnull DJFuture<DJValue> *)getFuture;
// `setValue` or `setException` can only be called once on a promise. After
// which the internal state becomes invalid.
- (void)setValue:(nonnull DJValue)val;
- (void)setValue:(nullable DJValue)val;
// for NSNull* (void)
- (void)setValue;
- (void)setException:(nonnull NSException *)exception;
Expand Down
Loading