SLCORE-1149 Trace execution of analysis requests and sensors #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblievremont
force-pushed
the
SLCORE-1149-analysis-tracing
branch
3 times, most recently
from
aab7fe4 to
58ef518
Compare
damien-urruty-sonarsource
approved these changes
Feb 3, 2025
| var sampleRateFromSystemProperty = System.getProperty(TRACES_SAMPLE_RATE_PROPERTY); | ||
| return Double.parseDouble(sampleRateFromSystemProperty); | ||
| } catch (RuntimeException e) { | ||
| return TRACES_SAMPLE_RATE_DEFAULT; |
There was a problem hiding this comment.
A small log here could help. Just in case...
|
|
||
| public SensorsExecutor(DefaultSensorContext context, SensorOptimizer sensorOptimizer, ProgressMonitor progress, Optional<List<ProjectSensor>> sensors) { | ||
| public SensorsExecutor(DefaultSensorContext context, SensorOptimizer sensorOptimizer, ProgressMonitor progress, @Nullable Trace trace, Optional<List<ProjectSensor>> sensors) { |
There was a problem hiding this comment.
I thought Nullable parameter injection was not working since the investigation I made recently around DBD and Java SE. But maybe in some specific contexts it does work 🤔
There was a problem hiding this comment.
It's a bit weird yes. For the sake of consistency, we could go with Optional (like for the list of sensors), it does not make a huge difference.
jblievremont
force-pushed
the
SLCORE-1149-analysis-tracing
branch
from
c318d46 to
9b4c482
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-1149