Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prs/update makefile #73

Merged
merged 11 commits into from
Oct 23, 2024
Merged

Prs/update makefile #73

merged 11 commits into from
Oct 23, 2024

Conversation

boekhorstb1
Copy link
Contributor

updates to Makefile in relation to update to README.md in this PR here #72

@boekhorstb1 boekhorstb1 self-assigned this Aug 26, 2024
@boekhorstb1 boekhorstb1 changed the base branch from main to prs/enhance-ceph-pools August 26, 2024 11:41
@boekhorstb1
Copy link
Contributor Author

note: currently branch is set up to merge into prs/enhance-ceph-pools

@NotTheEvilOne NotTheEvilOne force-pushed the prs/enhance-ceph-pools branch 7 times, most recently from 75c6ab3 to 463e5fb Compare September 3, 2024 08:07
Base automatically changed from prs/enhance-ceph-pools to main September 3, 2024 20:52
@boekhorstb1 boekhorstb1 force-pushed the prs/update-makefile branch 3 times, most recently from ca83f78 to 07e5cf2 Compare September 4, 2024 07:27
…o contain osism sepcific commands and more general commands

Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1 boekhorstb1 marked this pull request as ready for review September 4, 2024 07:48
@boekhorstb1 boekhorstb1 marked this pull request as draft September 10, 2024 09:42
@boekhorstb1 boekhorstb1 marked this pull request as ready for review September 10, 2024 10:13
boekhorstb1 added a commit that referenced this pull request Sep 10, 2024
Signed-off-by: Boekhorst <[email protected]>
scripts/osism/get_osism_configs_from_testbed.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@boekhorstb1
Copy link
Contributor Author

updated branch from main and reorganized consequently :)

Copy link
Contributor

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, please consider reverting your change in README.md to prevent merge conflicts with #72

README.md Outdated Show resolved Hide resolved
@NotTheEvilOne NotTheEvilOne merged commit 7c82cef into main Oct 23, 2024
3 checks passed
@NotTheEvilOne NotTheEvilOne deleted the prs/update-makefile branch October 23, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants