Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back multi-vp handling #182

Conversation

TimoGlastra
Copy link
Contributor

No description provided.

Signed-off-by: Timo Glastra <[email protected]>
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/mdoc-parsing@22c230c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
lib/evaluation/evaluationClientWrapper.ts 63.63% 8 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature/mdoc-parsing     #182   +/-   ##
=======================================================
  Coverage                        ?   92.80%           
=======================================================
  Files                           ?       66           
  Lines                           ?     2739           
  Branches                        ?      719           
=======================================================
  Hits                            ?     2542           
  Misses                          ?      192           
  Partials                        ?        5           
Flag Coverage Δ
unittest 92.80% <63.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanderPostma sanderPostma merged commit 20669be into Sphereon-Opensource:feature/mdoc-parsing Oct 31, 2024
3 checks passed
@sanderPostma
Copy link
Contributor

@TimoGlastra
I published two test builds.
5.0.0-unstable.20
5.0.0-unstable.21

20 was before merging back in, I had one test failing .in OID4VC/packages/siop-oid4vp/lib/tests/PresentationExchange.spec.ts
21 was after merging back in, I have 3 tests failing there.

With 5.0.0-unstable.18 & 19 it was still passing.
Will take a more detailed look after lunch

@TimoGlastra
Copy link
Contributor Author

I'm currently workign on the OID4VC PR btw!

@TimoGlastra
Copy link
Contributor Author

I wanted to do that as a follow up (currently fixing the tests)

@TimoGlastra
Copy link
Contributor Author

wIll update it against 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants