Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing reference.fab files #3681

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

10110111
Copy link
Contributor

This fixes #3680. I removed all the References sections in the Chinese and Anutan cultures in all languages.
Note that there was a dead link marked in some of the translations of the Chinese culture, I've preserved it in reference.fab just in case it's referenced somewhere in the text (and also to avoid changing the numeration of the links).

This commit also merges the "External links" section of the description
into reference.fab, removing it from the description.
This commit also removes the extraneous open-coded References section in
the description.
Copy link

github-actions bot commented Mar 21, 2024

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
  • Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
  • Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures (see info.ini file)?
  • Did you remember to define license parameter in sky cultures (see info.ini file)?
  • Did you remember to define region parameter in sky culture (see info.ini file)?

This is an automatically generated QA checklist based on modified files.

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w added this to the 24.1 milestone Mar 21, 2024
@alex-w alex-w merged commit 6bdb8f2 into Stellarium:master Mar 21, 2024
13 of 14 checks passed
@alex-w alex-w added the purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes
Development

Successfully merging this pull request may close these issues.

Some sky cultures don't install reference.fab
2 participants