fix the name in find query

[mosaicthej]

The .config installed by github's fast_float, makes the library to be exposed as FastFloat, not fast_float.

So current situation is that no matter if the library exist or not, it pulls from github remote anyways.

Also updated the version to be 6.1.3 as it's the newest release.

Description

Fixes # (issue)

The current CMakeLists would pull fast_float from github anyways irrespective if the library is installed or not.

I changed the NAME field to FastFloat so it would pick up if previously has been installed.

Type of change

• Housekeeping

How Has This Been Tested?

Tested with a clean install of fast_float library, then build stellarium. When change the NAME, cmake won't pull from remote.

Test Configuration:

• Operating system:
• • OS: Gentoo Linux x86_64
• • Kernel: 6.10.0-gentoo-x86_64
• Graphics Card: Intel Raptor Lake-P [Iris Xe Graphics], 13th Gen Intel i9-13900H (20) @ 5.200GHz

Checklist:

• My code follows the code style of this project.
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (header file)
• I have updated the respective chapter in the Stellarium User Guide
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[10110111]

Does it work if the user has version 6.1.0 installed?

[mosaicthej]

Does it work if the user has version 6.1.0 installed?

Probably not? it probably just pull in 6.1.3 from remote then, like what we used to always have. But in this way everyone would be having 6.1.3 with stellarium.

CMakeList's VERSION specifics the minimum version, so even if i entered 6.1.0, for people having 6.1.3 it would still work (i just tested on my system, it worked).

That was not the case with the main issue, the main issue is the CamelCase not snake_case for the fast_float (I know it's confusing, the package installed in system is FastFloat but the repo is called fast_float lol).

Do we want to use 6.1.0 (and higher) or use 6.1.3 (and higher)

https://github.com/fastfloat/fast_float/releases

From the release notes, there shouldn't be any ground-breaking change, I guess this commit might be something useful? fastfloat/fast_float#167

I just think it's also a good habit to keep it with the current version, maybe I should do in 2 commits as it's 2 different purposes.

Let me know what you think

[10110111]

Yes, I was just wondering if this is because of some name change (which some projects do, unfortunately), or simply because of my mistake. I see the following here, which makes me wonder.

add_library(fast_float INTERFACE)
add_library(FastFloat::fast_float ALIAS fast_float)

[alex-w]

Any news?

[github-actions]

Hello @mosaicthej!

We really need your feedback.

[alex-w]

Hmm… I found a similar patch for FreeBSD

[DarthGandalf]

I see the following here, which makes me wonder.

That defines how the target name will look like after successful find_package. But find_package itself looks at the filenames, which in the case of fast_float are set to FastFloat.

[10110111]

Now that I think of it, the change of the name shouldn't have bothered me too much, since fast_float library is just a temporary workaround until all the target machines' toolchains implement std::from_chars (see 389dbd5). Thus, we can just pull the latest version and follow whatever naming it defines, without much regard to what version is installed on user's machine (it's likely that none is even available from the repos of such old operating systems).

@DarthGandalf If you can confirm that this PR fixes the issue for you, I think we can merge it.

[DarthGandalf]

@10110111 I had opened #3949 which does essentially the same, without seeing this PR first :) This version should work too.

[github-actions]

This pull request is outdated, such, the problematic code replaced by new tool or feature...