Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let system-installed fast_float be found #3949

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

DarthGandalf
Copy link
Contributor

@DarthGandalf DarthGandalf commented Oct 14, 2024

Description

The library installs /usr/share/cmake/FastFloat/FastFloatConfig.cmake, so find_package(fast_float) cannot find it - find_package(FastFloat) can.

Only the CPMFindPackage line is relevant here, the other 2 are just for consistency, can revert them

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

By checking build log with libc++

Test Configuration:

  • Operating system: Gentoo
  • Graphics Card: n/a

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w
Copy link
Member

alex-w commented Oct 14, 2024

Some reimplementation of #3828?

@alex-w alex-w added this to the 24.4 milestone Oct 14, 2024
@alex-w alex-w added the dependencies dependencies (such like ShowMySky, QXlsx, etc.) related issues label Oct 14, 2024
@DarthGandalf
Copy link
Contributor Author

Ah, I haven't checked existing PRs

@DarthGandalf DarthGandalf deleted the fastfl branch October 14, 2024 12:23
@alex-w
Copy link
Member

alex-w commented Oct 14, 2024

Well, I see combined both PR looks like a complete patch.

@DarthGandalf DarthGandalf mentioned this pull request Oct 14, 2024
10 tasks
@alex-w
Copy link
Member

alex-w commented Oct 14, 2024

At least your patch is better, so, I reopened the PR

@DarthGandalf DarthGandalf restored the fastfl branch October 14, 2024 12:44
@DarthGandalf DarthGandalf reopened this Oct 14, 2024
@DarthGandalf
Copy link
Contributor Author

At least your patch is better

Not sure how it's better, but ok...

@10110111
Copy link
Contributor

At least your patch is better, so, I reopened the PR

Well the variable name is insignificant, since it's our own variable, but I'm OK with any of these patches.

@alex-w alex-w added os: linux Specific issues for Linux-family OS os: bsd Specific issues for BSD-family OS labels Oct 14, 2024
Copy link
Contributor

@10110111 10110111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this one is better for consistency of naming.

@alex-w alex-w merged commit 737851f into Stellarium:master Oct 14, 2024
28 of 29 checks passed
@DarthGandalf DarthGandalf deleted the fastfl branch October 14, 2024 13:04
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 22, 2024
Copy link

Hello @DarthGandalf!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 22, 2024
Copy link

Hello @DarthGandalf!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies dependencies (such like ShowMySky, QXlsx, etc.) related issues os: bsd Specific issues for BSD-family OS os: linux Specific issues for Linux-family OS
Development

Successfully merging this pull request may close these issues.

3 participants