-
-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let system-installed fast_float be found #3949
Conversation
Some reimplementation of #3828? |
Ah, I haven't checked existing PRs |
Well, I see combined both PR looks like a complete patch. |
At least your patch is better, so, I reopened the PR |
Not sure how it's better, but ok... |
Well the variable name is insignificant, since it's our own variable, but I'm OK with any of these patches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this one is better for consistency of naming.
Hello @DarthGandalf! Please check the fresh version (development snapshot) of Stellarium: |
Hello @DarthGandalf! Please check the latest stable version of Stellarium: |
Description
The library installs
/usr/share/cmake/FastFloat/FastFloatConfig.cmake
, sofind_package(fast_float)
cannot find it -find_package(FastFloat)
can.Only the
CPMFindPackage
line is relevant here, the other 2 are just for consistency, can revert themFixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
By checking build log with libc++
Test Configuration:
Checklist: