Fix rendering Twig hook message exception #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
fix/twig-render-exception
branch
2 times, most recently
from
b02ba01 to
1e88e9e
Compare
loic425
force-pushed
the
fix/twig-render-exception
branch
from
1e88e9e to
91ad8bb
Compare
Prometee
requested changes
Nov 7, 2024
src/TwigHooks/src/Hookable/Renderer/HookableTemplateRenderer.php
Outdated
Show resolved
Hide resolved
loic425
force-pushed
the
fix/twig-render-exception
branch
3 times, most recently
from
794bb21 to
cc575ae
Compare
loic425
changed the title
loic425
force-pushed
the
fix/twig-render-exception
branch
from
cc575ae to
7c176fe
Compare
Prometee
previously approved these changes
Nov 7, 2024
loic425
force-pushed
the
fix/twig-render-exception
branch
from
7c176fe to
fb7deeb
Compare
Prometee
approved these changes
Nov 7, 2024
loic425
commented
Nov 7, 2024
| @@ -42,12 +42,15 @@ public function render(AbstractHookable $hookable, HookableMetadata $metadata): | |||
| return $this->twig->render($hookable->template, [ | |||
| HooksRuntime::HOOKABLE_METADATA => $metadata, | |||
| ]); | |||
| } catch (HookRenderException $exception) { | |||
There was a problem hiding this comment.
if we do not catch this one, it will append the message with the parent template.
GSadee
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
