Add storage for filters #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diimpp
reviewed
Sep 25, 2024
src/Component/Symfony/Session/Filter/Storage/SessionFilterStorage.php
Outdated
Show resolved
Hide resolved
src/Component/Symfony/Session/Filter/Storage/SessionFilterStorage.php
Outdated
Show resolved
Hide resolved
src/Component/Tests/Integration/Filter/Storage/SessionFilterStorageTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmitri Perunov <[email protected]>
diimpp
reviewed
Sep 26, 2024
src/Component/Symfony/Session/Filter/Storage/SessionFilterStorage.php
Outdated
Show resolved
Hide resolved
src/Component/Tests/Integration/Filter/Storage/SessionFilterStorageTest.php
Outdated
Show resolved
Hide resolved
src/Component/Tests/Integration/Filter/Storage/SessionFilterStorageTest.php
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goal is to extract that https://github.com/Sylius/Sylius/blob/2.0/src/Sylius/Bundle/UiBundle/Storage/FilterStorage.php from UiBundle and be able use it in the new Sylius stack.
We need this one for "RedirectPathExtension" (from Ui bundle to Twig Extra package).
Then we'll need to extract AdminFilterSubscriber from AdminBundle (to move into AdminUi), but we can do this later.