Uplynk Ping API #35
Merged
Uplynk Ping API #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegRyz
force-pushed
the
feature/uplynk-ping
branch
from
62548de to
7c10750
Compare
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/network/UplynkAd.kt
Show resolved
Hide resolved
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkListener.kt
Outdated
Show resolved
Hide resolved
...ctors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/internal/PingScheduler.kt
Outdated
Show resolved
Hide resolved
… documentation but was provided in examples. Most likely it's a mistake in documentation
MattiasBuelens
approved these changes
Sep 5, 2024
hovig-theo
reviewed
Sep 6, 2024
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkListener.kt
Outdated
Show resolved
Hide resolved
...ectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkSsaiDescription.kt
Outdated
Show resolved
Hide resolved
...ectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkSsaiDescription.kt
Show resolved
Hide resolved
...ectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/UplynkSsaiDescription.kt
Show resolved
Hide resolved
| } | ||
|
|
||
| override suspend fun setSource(source: SourceDescription): SourceDescription { | ||
| adScheduler = null | ||
| pingScheduler?.destroy() |
There was a problem hiding this comment.
Since we have the resetSource() implemented, isn't these 2 lines redundant?
There was a problem hiding this comment.
resetSource() is only called when we set the source to null. Not sure wether it was intended or it's a bug in the THEOplayer SSAI API.
This is why it's duplicated here
There was a problem hiding this comment.
Aha, didn't realize that.. I expect reset gets called whenever a new source is set regardless if it's a null or not.
Let's discuss internally for the THEOplayer SSAI API.
.../uplynk/src/main/java/com/theoplayer/android/connector/uplynk/network/PreplayLiveResponse.kt
Outdated
Show resolved
Hide resolved
...main/java/com/theoplayer/android/connector/uplynk/internal/UplynkSsaiDescriptionConverter.kt
Outdated
Show resolved
Hide resolved
...plynk/src/main/java/com/theoplayer/android/connector/uplynk/internal/network/PingResponse.kt
Outdated
Show resolved
Hide resolved
...plynk/src/main/java/com/theoplayer/android/connector/uplynk/internal/network/PingResponse.kt
Outdated
Show resolved
Hide resolved
connectors/uplynk/src/main/java/com/theoplayer/android/connector/uplynk/network/UplynkAd.kt
Outdated
Show resolved
Hide resolved
OlegRyz
commented
Sep 6, 2024
...uplynk/src/main/java/com/theoplayer/android/connector/uplynk/internal/UplynkAdIntegration.kt
Outdated
Show resolved
Hide resolved
OlegRyz
commented
Sep 6, 2024
...main/java/com/theoplayer/android/connector/uplynk/internal/UplynkSsaiDescriptionConverter.kt
Outdated
Show resolved
Hide resolved
hovig-theo
reviewed
Sep 9, 2024
| } | ||
|
|
||
| override suspend fun setSource(source: SourceDescription): SourceDescription { | ||
| adScheduler = null | ||
| pingScheduler?.destroy() |
There was a problem hiding this comment.
Aha, didn't realize that.. I expect reset gets called whenever a new source is set regardless if it's a null or not.
Let's discuss internally for the THEOplayer SSAI API.
| @@ -33,5 +34,10 @@ internal data class MinimalPreplayResponse( | |||
|
|
|||
| internal class PreplayInternalResponse(val body: String, private val json: Json) { | |||
There was a problem hiding this comment.
Nitpick: let's rename this to PreplayInternalVodResponse to match the public classes.
There was a problem hiding this comment.
Thanks, renamed that
hovig-theo
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.