Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplynk Ping API #35
Uplynk Ping API #35
Changes from 11 commits
e6f1921
453ed6b
75b2bb4
8ccc77d
689beb4
7c10750
6a909ab
6711d80
654129b
1417fc0
2ca3306
3f6da7f
af63190
95b87a4
33c94f8
72710af
fbaed1b
9dc8216
ca47878
82305b6
0d77e3c
5666726
fdf08d8
47644f1
0584cf6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have the
resetSource()
implemented, isn't these 2 lines redundant?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resetSource()
is only called when we set thesource
tonull
. Not sure wether it was intended or it's a bug in the THEOplayer SSAI API.This is why it's duplicated here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, didn't realize that.. I expect reset gets called whenever a new source is set regardless if it's a null or not.
Let's discuss internally for the THEOplayer SSAI API.