Offset the playback position from stream start for Yospace DVRLive sessions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive-playback-position-offset We need to offset the playback position for DVRLive sessions
🦋 Changeset detectedLatest commit: 2f9e46a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your contribution! Indeed, it seems like we've missed that part about DVRLive sessions in our integration. 😅 I've manually tested this with this sample DVRLive stream (also used in the Yospace JavaScript sample applications). Looks pretty good! 👍 |
GillesMoris-Dolby
approved these changes
May 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour of the THEOplayer Yospace web connector is to always report the player current time to the Yospace SDK regardless of the playback mode. But for Yospace DVRLive sessions (called
livepausein the connector) the time should be offset from stream start.See https://developer.yospace.com/sdk-documentation/javascript/userguide/latest/en/provide-necessary-information-to-the-sdk.html#video-playback-position for more information.
Examples of this logic is also available in the Yospace sample reference apps (see shaka/shaka-adapter.js).