Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comscore Connector #8

Merged
merged 68 commits into from
Apr 11, 2024
Merged

Comscore Connector #8

merged 68 commits into from
Apr 11, 2024

Conversation

wjoosen
Copy link
Contributor

@wjoosen wjoosen commented Mar 22, 2024

Cleanup of the old Comscore integration. It now has a similar structure to its Android and iOS counterparts.

Tested with

  • THEOAds and Google IMA for CSAI
  • Google DAI for SSAI

Copy link

changeset-bot bot commented Mar 22, 2024

🦋 Changeset detected

Latest commit: 05e8db3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@theoplayer/comscore-connector-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wjoosen wjoosen marked this pull request as draft March 22, 2024 14:07
@MattiasBuelens
Copy link
Contributor

@wjoosen I've rebased your PR, and fixed the integration with the npm workspace.

Make sure to update your local branch when you continue working on this. 😉

@wjoosen wjoosen marked this pull request as ready for review April 10, 2024 07:34
comscore/src/comscore/comscore.js Outdated Show resolved Hide resolved
comscore/README.md Outdated Show resolved Hide resolved
comscore/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@MattiasBuelens MattiasBuelens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it! 🚀

@MattiasBuelens MattiasBuelens merged commit b81e132 into main Apr 11, 2024
1 check passed
@MattiasBuelens MattiasBuelens deleted the comscore branch April 11, 2024 13:02
georgechoustoulakis pushed a commit that referenced this pull request Aug 2, 2024
georgechoustoulakis pushed a commit that referenced this pull request Aug 2, 2024
Bugfix/redundant emptied listener

Approved-by: Michel Roofthooft
Approved-by: Tom Van Laerhoven
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants