Feature: Added move query functionality to Heihachi frame data bot #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
/fd
Why:
To extend the functionality of the bot. During development I realized that the alias lookup was only enabled for the
/fd
command. From my personal experience most people just use/character
so I enabled aliases there as well.How:
I added a new move search command
/ms
that takes in acondition
(>, <, == etc.)frame_value
,situation
(hit, block, startup). This data is all used to traverse the character's move-list json to find applicable moves.I noticed some of the data was malformed so I also created a
_sanitize_frame_data
function to clean those up before comparison.I flatted the aliases from
CHARACTER_ALIAS
and combined them with the list ofCharacterNames
Searching moves by frames
Short hand character lookup by alias